fix: resolve split pane PR #585 conflicts against master#620
Open
RajPabnani03 wants to merge 3 commits intoathasdev:masterfrom
Open
fix: resolve split pane PR #585 conflicts against master#620RajPabnani03 wants to merge 3 commits intoathasdev:masterfrom
RajPabnani03 wants to merge 3 commits intoathasdev:masterfrom
Conversation
…olish Rebased split pane work onto current master (excluding window.rs which is already fixed upstream). Changes: - Raise minimum pane threshold to 20% - Normalize collapsed splits to 40/60 on drag release - Repair bad split ratios on restore/startup - Generic splits open empty panes (no tab duplication) - Calmer active-pane focus with ring styling - Slimmer resize handles with expanded hit areas - Always-visible tab bar for empty panes - Hide nonessential chrome in narrow panes - Split Pane naming (was Split Editor) - Test coverage for split and normalize behavior
…olish Reapplied split pane work onto latest upstream master. Upstream already merged: pane-tree helpers, resize handle, pane store tests, pane keyboard hooks, menu events. Remaining changes: - Flatten nested same-direction splits in SplitViewRoot - Repair collapsed split ratios on mount - Calmer active-pane focus ring styling - Tab bar responsive hiding and visual polish - Split Pane naming (was Split Editor)
Author
|
Hi @athasdev maintainers — this PR is now up to date with the latest |
Author
|
Hi maintainers, This PR is now up to date with Summary of what this PR delivers:
The PR is merge-ready — no conflicts, no failing checks. Would appreciate a review and merge when you have a moment. Thanks! cc: @athasdev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the merge conflicts from #585 (Split Pane improvements) against the latest
master.What changed upstream since #585 was opened:
normalizePanePairSizes,getCollapsedSplitRepairs) merged tomasterlucide-reactto@phosphor-icons/reactWhat this PR includes:
masterSplitViewRootCloses #585 (supersedes with resolved conflicts).