Refactor CI/CD pipeline in cd.yml: streamline setup steps and improve artifact handling

Author: atick-faisal

.github/workflows/cd.yml

@@ -16,28 +16,15 @@ jobs:
       - name: ✅ Validate Gradle Wrapper
         uses: gradle/actions/wrapper-validation@v4
 
-      - name: 📜 Set up Google Services
-        run: |
-          touch app/google-services.json
-          echo "${CONTENT// /}" | base64 --decode > app/google-services.json
-        env:
-          CONTENT: ${{ secrets.GOOGLE_SERVICES }}
-
       - name: 🏗️ Set up JDK 21
         uses: actions/setup-java@v5
         with:
           java-version: 21
           distribution: 'temurin'
           cache: gradle
 
-      - name: 💎 Setup Ruby & Bundler
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 3.0
-          bundler-cache: true
-
-      - name: ⚙️ Setup Gradle
-        uses: gradle/actions/setup-gradle@v4
+      - name: 🧼 Run Spotless Check
+        run: ./gradlew spotlessCheck --init-script gradle/init.gradle.kts --no-configuration-cache
 
   build:
     name: 🏗️ Build Signed APK
@@ -48,6 +35,23 @@ jobs:
       - name: ⬇️ Checkout Repository
         uses: actions/checkout@v5
 
+      - name: ✅ Validate Gradle Wrapper
+        uses: gradle/actions/wrapper-validation@v4
+
+      - name: 🏗️ Set up JDK 21
+        uses: actions/setup-java@v5
+        with:
+          java-version: 21
+          distribution: 'temurin'
+          cache: gradle
+
+      - name: 📜 Set up Google Services
+        run: |
+          touch app/google-services.json
+          echo "${CONTENT// /}" | base64 --decode > app/google-services.json
+        env:
+          CONTENT: ${{ secrets.GOOGLE_SERVICES }}
+
       - name: 🔑 Set up Signing Key
         run: |
           touch app/key.jks
@@ -67,7 +71,9 @@ jobs:
       - name: 📦 Upload APK as Artifact
         uses: actions/upload-artifact@v4
         with:
+          name: release-apk
           path: app/build/outputs/apk/release/*.apk
+          retention-days: 30
 
   release:
     name: 🚀 Publish Release
@@ -79,16 +85,28 @@ jobs:
       - name: ⬇️ Checkout Repository
         uses: actions/checkout@v5
 
+      - name: 📦 Download APK Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: release-apk
+          path: ./apk
+
+      - name: 💎 Setup Ruby & Bundler
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0
+          bundler-cache: true
+
       - name: 📝 Create GitHub Release
         uses: softprops/action-gh-release@v2
         if: startsWith(github.ref, 'refs/tags/')
         with:
           body_path: CHANGELOG.md
-          files: app/build/outputs/apk/release/*.apk
+          files: ./apk/*.apk
 
       - name: ☁️ Upload to Play Store
         run: |
           echo "${PLAY_STORE_JSON// /}" | base64 --decode > fastlane/play-store.json
           bundle exec fastlane android deploy
         env:
-          PLAY_STORE_JSON: ${{ secrets.PLAY_STORE_JSON }}
+          PLAY_STORE_JSON: ${{ secrets.PLAY_STORE_JSON }}