Changes in the way Byte instances are created

Author: sunye

commons-core/src/main/java/fr/inria/atlanmod/commons/collect/MoreArrays.java

@@ -189,6 +189,29 @@ public static <T> T[] addAll(T[] array, int index, Collection<? extends T> eleme
         return newArray;
     }
 
+    /**
+     * Adds all {@code array2} at the end of the {@code array1}.
+     *
+     * @param array1    the array to add the element to
+     * @param array2    the values to add
+     *
+     * @return a new array of bytes containing all the existing elements in arrays 1 and 2.
+     *
+     * @throws NullPointerException if any argument is {@code null}
+     */
+    @Nonnull
+    public static byte[] addAll(byte[] array1, byte... array2) {
+        checkNotNull(array1, "array1");
+        checkNotNull(array2, "array2");
+
+        final byte[] newArray = new byte[array1.length + array2.length];
+        System.arraycopy(array1, 0, newArray, 0, array1.length);
+        System.arraycopy(array2, 0, newArray, array1.length, array2.length);
+
+        return newArray;
+
+    }
+
     /**
      * Removes the element at the specified {@code index} from the specified {@code array}.
      *

commons-core/src/main/java/fr/inria/atlanmod/commons/primitive/Bytes.java

@@ -11,16 +11,14 @@
 import fr.inria.atlanmod.commons.Throwables;
 import fr.inria.atlanmod.commons.annotation.Static;
 
+import javax.annotation.Nonnull;
+import javax.annotation.ParametersAreNonnullByDefault;
 import java.nio.charset.StandardCharsets;
 import java.nio.charset.UnsupportedCharsetException;
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 
-import javax.annotation.Nonnull;
-import javax.annotation.ParametersAreNonnullByDefault;
-
 import static fr.inria.atlanmod.commons.Preconditions.checkEqualTo;
 import static fr.inria.atlanmod.commons.Preconditions.checkNotNull;
 
@@ -260,7 +258,7 @@ public static List<Byte> asList(byte... primitiveArray) {
         }
         List<Byte> byteCollection = new ArrayList<>(primitiveArray.length);
         for (byte each : primitiveArray) {
-            byteCollection.add(new Byte(each));
+            byteCollection.add(Byte.valueOf(each));
         }
         return byteCollection;
     }

commons-core/src/test/java/fr/inria/atlanmod/commons/collect/MoreArraysTest.java

@@ -125,6 +125,17 @@ public void testAdd() {
                 .isInstanceOf(IndexOutOfBoundsException.class);
     }
 
+    @Test
+    public void testAddAllBytes() {
+        byte[] array1 = new byte[] {6,5,4,3,2,1};
+        byte[] array2 = new byte[] {1, 2, 3};
+        byte[] expected = new byte[] {6,5,4,3,2,1,1,2,3};
+
+        byte[] joinedArray = MoreArrays.addAll(array1, array2);
+
+        assertThat(joinedArray).isEqualTo(expected);
+    }
+
     @Test
     public void testRemove() {
         Integer[] array0 = new Integer[]{0, 1, 2, 3, 4};

commons-core/src/test/java/fr/inria/atlanmod/commons/primitive/BytesTest.java

@@ -124,7 +124,7 @@ public void testToArray() {
         byte[] expected = new byte[] {1, 2, 3, 4, 5};
         List<Byte> boxedList = new ArrayList<>();
         for(byte each : expected) {
-            boxedList.add(new Byte(each));
+            boxedList.add(Byte.valueOf(each));
         }
         assertThat(boxedList.size()).isEqualTo(expected.length);
         assertThat(Bytes.toArray(boxedList)).isEqualTo(expected);