Skip to content

Commit e752405

Browse files
authored
Merge pull request #409 from atom-community/dump-symbols
2 parents dff0ea0 + 38e5586 commit e752405

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

script/lib/dump-symbols.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,12 @@ function dumpSymbol(binaryPath) {
2828
minidump.dumpSymbol(binaryPath, function(error, content) {
2929
if (error) {
3030
// fswin.node is only used on windows, ignore the error on other platforms
31-
if (process.platform !== 'win32' && binaryPath.match(/fswin.node/))
31+
if (process.platform !== 'win32') {
32+
console.warn(
33+
`\n##[warning] Failed to dump the symbols via minidump. ${error}. Ignoring the error...`
34+
);
3235
return resolve();
36+
}
3337
throw new Error(error);
3438
} else {
3539
const moduleLine = /MODULE [^ ]+ [^ ]+ ([0-9A-F]+) (.*)\n/.exec(

0 commit comments

Comments
 (0)