Merge pull request #1087 from maralv/master

🐛 Fix base64 encoded image viewing in package README files.

Author: Winston Liu

lib/package-readme-view.js

@@ -23,6 +23,11 @@ function sanitize (html, readmeSrc) {
       changeImageSrc = false
     }
 
+    // If src contains a base64 encoded image it must be left unchanged
+    if (/^data:image\/.*;base64/i.test(imageSrc)) {
+      changeImageSrc = false;
+    }
+
     // If path is absolute on file system it must be a local file, e.g. emoji
     if (path.isAbsolute(imageSrc)) {
       changeImageSrc = false

spec/fixtures/package-with-readme/README.md

@@ -6,6 +6,7 @@ I am a Readme!
 
 ![AbsoluteImage](https://example.com/static/image.jpg)
 ![RelativeImage](static/image.jpg)
+![Base64Image](data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==)
 
 <script>alert('oh, hai');</script>
 <iframe src="https://atom.io"></iframe>

spec/package-detail-view-spec.coffee

@@ -93,6 +93,7 @@ describe "PackageDetailView", ->
     expect(view.element.querySelectorAll('.package-readme input[type="checkbox"][disabled]').length).toBe(2)
     expect(view.element.querySelector('img[alt="AbsoluteImage"]').getAttribute('src')).toBe('https://example.com/static/image.jpg')
     expect(view.element.querySelector('img[alt="RelativeImage"]').getAttribute('src')).toBe('https://github.com/example/package-with-readme/blob/master/static/image.jpg')
+    expect(view.element.querySelector('img[alt="Base64Image"]').getAttribute('src')).toBe('data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==')
 
   it "renders the README when the package path is undefined", ->
     atom.packages.loadPackage(path.join(__dirname, 'fixtures', 'package-with-readme'))