Speed up search by avoiding apm overhead

Author: Ingramz

lib/atom-io-client.coffee

@@ -187,3 +187,31 @@ class AtomIoClient
 
   getCachePath: ->
     @cachePath ?= path.join(remote.app.getPath('userData'), 'Cache', 'settings-view')
+
+  search: (query, type, callback) ->
+    qs = {q: query}
+
+    if type is 'packages'
+      qs.filter = 'package'
+    else if type is 'themes'
+      qs.filter = 'theme'
+
+    options = {
+      url: "#{@baseURL}packages/search"
+      headers: {'User-Agent': navigator.userAgent}
+      qs: qs
+    }
+
+    new Promise (resolve, reject) ->
+      request options, (err, res, body) ->
+        if err
+          reject err
+        else
+          try
+            resolve JSON.parse body
+              .filter (pack) -> pack.releases?.latest?
+              .map ({readme, metadata, downloads, stargazers_count}) ->
+                Object.assign metadata, {readme, downloads, stargazers_count}
+              .sort (a, b) -> b.downloads - a.downloads
+          catch error
+            reject error

lib/install-panel.js

@@ -206,12 +206,8 @@ export default class InstallPanel {
     this.refs.searchMessage.textContent = `Searching ${this.searchType} for \u201C${query}\u201D\u2026`
     this.refs.searchMessage.style.display = ''
 
-    const opts = {}
-    opts[this.searchType] = true
-    opts['sortBy'] = 'downloads'
-
     try {
-      let packages = (await this.packageManager.search(query, opts)) || []
+      const packages = (await this.client.search(query, this.searchType)) || []
       this.refs.resultsContainer.innerHTML = ''
       this.refs.searchMessage.style.display = 'none'
       if (packages.length === 0) {

spec/install-panel-spec.coffee

@@ -60,7 +60,7 @@ describe 'InstallPanel', ->
 
   describe "searching packages", ->
     it "highlights exact name matches", ->
-      spyOn(@packageManager, 'search').andCallFake ->
+      spyOn(@panel.client, 'search').andCallFake ->
         new Promise (resolve, reject) -> resolve([ {name: 'not-first'}, {name: 'first'} ])
       spyOn(@panel, 'getPackageCardView').andCallThrough()
 
@@ -72,7 +72,7 @@ describe 'InstallPanel', ->
         expect(@panel.getPackageCardView.argsForCall[1][0].name).toEqual 'not-first'
 
     it "prioritizes partial name matches", ->
-      spyOn(@packageManager, 'search').andCallFake ->
+      spyOn(@panel.client, 'search').andCallFake ->
         new Promise (resolve, reject) -> resolve([ {name: 'something else'}, {name: 'partial name match'} ])
       spyOn(@panel, 'getPackageCardView').andCallThrough()