Commit e076590
committed
address review (codex): debounce inline Python path input, gate arch warning to darwin/arm64
* LocalSetupPanel: the inline path input fired onPythonPathChange on
every keystroke. In the VideoGen consumer that meant a settings PATCH
+ a ~1-2s status re-probe per character. Decouple via local draft
state; commit on 800ms debounce or onBlur. Programmatic updates
(Detect, Switch-to-arm64, Create-venv) still call onPythonPathChange
directly so they take effect immediately.
* /api/image-gen/setup/check: generic interpreterArch !== HOST_ARCH
would false-positive on Windows (Python reports `AMD64` vs Node's
`x86_64`) and on hypothetical arm64 Linux where mlx isn't even in
REQUIRED_PACKAGES. Gate the warning to darwin/arm64 with an x86_64
interpreter — the only configuration where mlx actually breaks.
The third codex finding (hfDownload.js falls back to broken FLUX.2 venv)
is in a file not yet on origin and not part of this PR's surface; left
for whichever branch ships hfDownload.1 parent df500e9 commit e076590
2 files changed
Lines changed: 29 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
15 | 34 | | |
16 | 35 | | |
17 | 36 | | |
| |||
143 | 162 | | |
144 | 163 | | |
145 | 164 | | |
146 | | - | |
147 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
148 | 168 | | |
149 | 169 | | |
150 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
685 | 685 | | |
686 | 686 | | |
687 | 687 | | |
688 | | - | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
689 | 695 | | |
690 | 696 | | |
691 | 697 | | |
| |||
0 commit comments