Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Nested fetch state#4

Open
dmitryshelomanov wants to merge 5 commits into
atomixinteractions:masterfrom
dmitryshelomanov:master
Open

Nested fetch state#4
dmitryshelomanov wants to merge 5 commits into
atomixinteractions:masterfrom
dmitryshelomanov:master

Conversation

@dmitryshelomanov

@dmitryshelomanov dmitryshelomanov commented Mar 27, 2019

Copy link
Copy Markdown
Member

Problem

Many fetch state in a flat state object

Solution

Add support fetch in nested state
For example

  const initial = {
    fetching: {
      main: initialFetching,
      apply: initialFetching,
    },
  }
  const symbiotes = {
    fetchNewsHandler: createFetching("fetching.main"),
    applyNewsHandler: createFetching("fetching.apply"),
  }

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 32

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 47.273%

Totals Coverage Status
Change from base Build 31: 2.2%
Covered Lines: 23
Relevant Lines: 43

💛 - Coveralls

@coveralls

coveralls commented Mar 27, 2019

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 35

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 47.273%

Totals Coverage Status
Change from base Build 31: 2.2%
Covered Lines: 23
Relevant Lines: 43

💛 - Coveralls

@sergeysova

Copy link
Copy Markdown
Member

Please, add tests to check for deep level foo.bar.baz

@dmitryshelomanov

Copy link
Copy Markdown
Member Author

@sergeysova I added random deep lvl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants