Skip to content

Commit 4e0630a

Browse files
committed
update todo list
1 parent b38bb2d commit 4e0630a

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

.github/CONTRIBUTING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ Please note that the tidyhydro project is released with a [Contributor Code of C
5252

5353
-[ ] KGE Score
5454

55+
-[ ] MSDR - mean squared deviation ratio [@oliverTutorialGuideGeostatistics2014]
56+
57+
-[x] RMSE
58+
5559
### Regression
5660
-[ ] PPCC - maximizes the probability plot correlation coefficient [@helselStatisticalMethodsWater2002, p.253]
5761

@@ -61,6 +65,3 @@ Please note that the tidyhydro project is released with a [Contributor Code of C
6165

6266
-[ ] MSPE - model standard percentage error log and nonlog [@rasmussenGuidelinesProceduresComputing2009, p. 13]
6367

64-
-[x] RMSE
65-
66-
-[ ] Coefficient of Variation

R/mse.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ mse_vec <- function(
9999
mse_cpp(truth, estimate, na_rm = na_rm, sqrt = FALSE)
100100
}
101101

102+
# TODO:
103+
# Add description and details
104+
102105
#' Root Mean Squared Error (RMSE)
103106
#' @keywords gof
104107
#'

README.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,4 @@ Please note that the tidyhydro project is released with a [Contributor Code of C
100100

101101
## See also
102102
* [`hydroGOF`](https://github.com/hzambran/hydroGOF) - Goodness-of-fit functions for comparison of simulated and observed hydrological time series.
103-
* [`yardstick`](https://github.com/tidymodels/yardstick/tree/main) - tidy methods for models performance assessment.
103+
* [`yardstick`](https://github.com/tidymodels/yardstick/tree/main) - tidy methods for models performance assessment.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ bench::mark(
128128
#> # A tibble: 3 × 6
129129
#> expression min median `itr/sec` mem_alloc `gc/sec`
130130
#> <bch:expr> <dbl> <dbl> <dbl> <dbl> <dbl>
131-
#> 1 tidyhydro 1 1 30.2 NaN NaN
132-
#> 2 hydroGOF 14.8 20.0 1 Inf Inf
133-
#> 3 baseR 8.44 10.3 2.55 Inf Inf
131+
#> 1 tidyhydro 1 1 28.9 NaN NaN
132+
#> 2 hydroGOF 14.8 19.2 1 Inf Inf
133+
#> 3 baseR 8.46 10.8 2.41 Inf Inf
134134
```
135135

136136
## Code of Conduct

0 commit comments

Comments
 (0)