Skip to content

Modify splash screen auto-hide behavior#3

Open
kevinmartin33 wants to merge 4 commits into
attarchi:masterfrom
kevinmartin33:master
Open

Modify splash screen auto-hide behavior#3
kevinmartin33 wants to merge 4 commits into
attarchi:masterfrom
kevinmartin33:master

Conversation

@kevinmartin33
Copy link
Copy Markdown

@kevinmartin33 kevinmartin33 commented Sep 9, 2025

-- iOS
Added a condition to only auto-hide the splash screen if not forced to keep it visible until an explicit hide() is called.

-- Android
Add compatibility with RN 0.81 / Safely retrieves the Activity (nullable) and passes it to hide()

Added a condition to only auto-hide the splash screen if not forced to keep it visible until an explicit hide() is called.
Compatibility with react native 0.81
Fix missing newline at end of file.
Only auto-hide if not forced to keep splash until explicit hide() is called
@mateattilabarna
Copy link
Copy Markdown

@attarchi

What do you think, can you merge this PR?
In current version android doesn't build because of this row:

SplashScreen.hide(currentActivity)

Thank you in advance!

@mateattilabarna
Copy link
Copy Markdown

@attarchi

Also I would have another question:

setupCustomLottieSplash is not available on ios and 3.0.1 is not available on npm. Can I ask you to check these?
Thank you in advance!

@mateattilabarna
Copy link
Copy Markdown

@attarchi

What do you think, you will have time for check this PR?

@attarchi
Copy link
Copy Markdown
Owner

@kevinmartin33 @mateattilabarna

Thank you very much for your collaboration, and sorry for the delayed response.

The forceToCloseByHideMethod flag controls whether the manual hide method is enabled or disabled. I removed the previous behavior intentionally to achieve this.

If you think we need a different approach for the hiding behavior, I’d suggest adding a separate switch for it - maybe an attribute like hideOnlyByRN.

Do you think it makes sense?

@mateattilabarna
Copy link
Copy Markdown

mateattilabarna commented Oct 14, 2025

@attarchi

Thank you, it makes sense. What do you think, I should open a new PR only for the android fix?

Screenshot 2025-10-14 at 10 31 04

Also can you check why setupCustomLottieSplash is not available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants