Skip to content

Commit 2eb44a4

Browse files
Minor improvements
1 parent b7a1c00 commit 2eb44a4

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

templates/guidelines/base.njk

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,17 @@
2323

2424
### Review Focus Areas:
2525
- **Potential Bugs**: Identify logic errors, edge cases, null pointer issues, race conditions
26-
- **Security Concerns**: Look for potential vulnerabilities, input validation, authentication issues only if the code in question security-sensitive.
26+
- **Security Concerns**: Look for potential vulnerabilities, input validation, authentication issues.
2727
- **Documentation**: Check if documentation is consistent with the code.
2828

2929
### Review Areas to Avoid:
3030
- **Code Style**:
3131
- **Readability**:
3232
- **Performance**:
3333
- **Testing**:
34+
- **Compiler/Build/Import errors**
35+
- **Linter/Formatter issues**:
36+
- **Nitpicks or subjective issues**:
3437

3538
### Review Philosophy:
3639
- Prioritize helping the author improve their code over finding every possible issue
@@ -42,9 +45,4 @@
4245
### Communication Style:
4346
- Use collaborative language ("we could", "consider", "what do you think about")
4447
- Explain the reasoning behind suggestions to help the author learn
45-
- Consider existing reviews, do not be repetitive with other reviews
46-
47-
### Scope Considerations:
48-
- Focus on the changes in this PR rather than suggesting broader refactoring
49-
- Consider the complexity and risk level when deciding which issues to raise
50-
- Balance thoroughness with practicality - not every suggestion needs to be addressed immediately
48+
- Consider existing reviews, do not be repetitive with other reviews

0 commit comments

Comments
 (0)