Fix KeyError when GitHub repo move response lacks full_name

Signed-off-by: Himasree Kolathur <himaa@Himasrees-MacBook-Air.local>
Signed-off-by: HimasreeKolathur24 <himasrikolathur@gmail.com>

Author: Himasree Kolathur

augur/tasks/github/detect_move/core.py

@@ -12,24 +12,19 @@
 
 
 class RepoMovedException(Exception):
-    def __init__(self, message, new_url=None): 
+    def __init__(self, message, new_url=None):
         super().__init__(message)
-        self.new_url = new_url 
+        self.new_url = new_url
+
 
 class RepoGoneException(Exception):
     pass
 
 
-def update_repo_with_dict(repo,new_dict,logger):
+def update_repo_with_dict(repo, new_dict, logger):
     """
-        Update a repository record in the database using a dictionary tagged with
-        the appropriate table fields
-
-        Args:
-            repo: orm repo object to update
-            new_dict: dict of new values to add to the repo record
-            logger: logging object
-            db: db object
+    Update a repository record in the database using a dictionary
+    tagged with the appropriate table fields.
     """
     to_insert = dict(repo.__dict__)
     del to_insert['_sa_instance_state']
@@ -40,66 +35,86 @@ def update_repo_with_dict(repo,new_dict,logger):
     with DatabaseSession(logger) as session:
         previous_alias = HistoricalRepoURLs(repo_id=repo_id, git_url=old_url)
         try:
-            result = session.add(previous_alias)
+            session.add(previous_alias)
             session.commit()
-        except IntegrityError as e: #Unique violation
-            session.rollback()    
+        except IntegrityError:
+            session.rollback()
 
     to_insert.update(new_dict)
 
-    result = bulk_insert_dicts(logger, to_insert, Repo, ['repo_id'])
+    bulk_insert_dicts(logger, to_insert, Repo, ['repo_id'])
 
     url = to_insert['repo_git']
-    logger.info(f"Updated repo {old_url} to {url} and set alias\n")
+    logger.info(f"Updated repo {old_url} to {url} and set alias")
     return url
 
 
-
 def extract_owner_and_repo_from_endpoint(key_auth, url, logger):
     response_from_gh = hit_api(key_auth, url, logger)
-
     page_data = parse_json_response(logger, response_from_gh)
 
-    full_repo_name = page_data['full_name']
+    full_repo_name = page_data.get('full_name')
 
-    splits = full_repo_name.split('/')
+    # ✅ FIX FOR #3621
+    if not full_repo_name:
+        logger.warning(
+            f"GitHub repo move task: 'full_name' missing in page_data. "
+            f"Keys present: {list(page_data.keys())}"
+        )
+        return None, None
 
-    return splits[0], splits[-1]
+    owner, repo = full_repo_name.split('/')
+    return owner, repo
 
-def ping_github_for_repo_move(session, key_auth, repo, logger,collection_hook='core'):
 
+def ping_github_for_repo_move(session, key_auth, repo, logger, collection_hook='core'):
     owner, name = get_owner_repo(repo.repo_git)
     url = f"https://api.github.com/repos/{owner}/{name}"
 
     attempts = 0
     while attempts < 10:
         response_from_gh = hit_api(key_auth, url, logger, follow_redirects=False)
-
         if response_from_gh:
             break
-
         attempts += 1
 
     if attempts >= 10:
         logger.error(f"Could not check if repo moved because the api timed out 10 times. Url: {url}")
         raise Exception(f"ERROR: Could not get api response for repo: {url}")
 
-    #Update Url and retry if 301
-    #301 moved permanently 
+    # --------------------
+    # 301: Repo moved
+    # --------------------
     if response_from_gh.status_code == 301:
-        redirect_location = response_from_gh.headers.get('location') or response_from_gh.headers.get('Location')
+        redirect_location = (
+            response_from_gh.headers.get('location')
+            or response_from_gh.headers.get('Location')
+        )
+
         if not redirect_location:
-            logger.error(f"Could not check if repo moved because the redirect location is not present. Url: {url}")
+            logger.error(f"Redirect location missing for repo: {url}")
             raise Exception(f"ERROR: Could not get redirect location for repo: {url}")
 
-        owner, name = extract_owner_and_repo_from_endpoint(key_auth, redirect_location, logger)
+        owner, name = extract_owner_and_repo_from_endpoint(
+            key_auth, redirect_location, logger
+        )
+
+        # ✅ SAFETY CHECK (KeyError fix)
+        if not owner or not name:
+            logger.error(
+                f"GitHub repo move task: Unable to extract owner/repo "
+                f"from redirect URL {redirect_location}"
+            )
+            raise RepoMovedException(
+                "Repo moved but new location could not be determined",
+                new_url=redirect_location
+            )
 
         try:
             old_description = str(repo.description)
         except Exception:
             old_description = ""
 
-        #Create new repo object to update existing
         repo_update_dict = {
             'repo_git': f"https://github.com/{owner}/{name}",
             'repo_path': None,
@@ -109,46 +124,61 @@ def ping_github_for_repo_move(session, key_auth, repo, logger,collection_hook='c
 
         new_url = update_repo_with_dict(repo, repo_update_dict, logger)
 
-        raise RepoMovedException("ERROR: Repo has moved! Resetting Collection!", new_url=new_url)
-    
-    #Mark as ignore if 404
+        raise RepoMovedException(
+            "ERROR: Repo has moved! Resetting Collection!",
+            new_url=new_url
+        )
+
+    # --------------------
+    # 404: Repo deleted
+    # --------------------
     if response_from_gh.status_code == 404:
         repo_update_dict = {
             'repo_git': repo.repo_git,
             'repo_path': None,
             'repo_name': None,
-            'description': f"During our check for this repo on {datetime.today().strftime('%Y-%m-%d')}, a 404 error was returned. The repository does not appear to have moved. Instead, it appears to be deleted",
+            'description': (
+                f"During our check for this repo on "
+                f"{datetime.today().strftime('%Y-%m-%d')}, a 404 error was returned. "
+                f"The repository does not appear to have moved. Instead, it appears to be deleted"
+            ),
             'data_collection_date': datetime.today().strftime('%Y-%m-%dT%H:%M:%SZ')
-            }
+        }
 
         update_repo_with_dict(repo, repo_update_dict, logger)
 
-        statusQuery = session.query(CollectionStatus).filter(CollectionStatus.repo_id == repo.repo_id)
-
-        collectionRecord = execute_session_query(statusQuery,'one')
+        status_query = session.query(CollectionStatus).filter(
+            CollectionStatus.repo_id == repo.repo_id
+        )
+        collection_record = execute_session_query(status_query, 'one')
 
-        collectionRecord.core_status = CollectionState.IGNORE.value
-        collectionRecord.core_task_id = None
-        collectionRecord.core_data_last_collected = datetime.today().strftime('%Y-%m-%dT%H:%M:%SZ')
+        now = datetime.today().strftime('%Y-%m-%dT%H:%M:%SZ')
 
-        collectionRecord.secondary_status = CollectionState.IGNORE.value
-        collectionRecord.secondary_task_id = None
-        collectionRecord.secondary_data_last_collected = datetime.today().strftime('%Y-%m-%dT%H:%M:%SZ')
+        collection_record.core_status = CollectionState.IGNORE.value
+        collection_record.core_task_id = None
+        collection_record.core_data_last_collected = now
 
-        collectionRecord.facade_status = CollectionState.IGNORE.value
-        collectionRecord.facade_task_id = None
-        collectionRecord.facade_data_last_collected = datetime.today().strftime('%Y-%m-%dT%H:%M:%SZ')
+        collection_record.secondary_status = CollectionState.IGNORE.value
+        collection_record.secondary_task_id = None
+        collection_record.secondary_data_last_collected = now
 
-        collectionRecord.ml_status = CollectionState.IGNORE.value
-        collectionRecord.ml_task_id = None
-        collectionRecord.ml_data_last_collected = datetime.today().strftime('%Y-%m-%dT%H:%M:%SZ')
+        collection_record.facade_status = CollectionState.IGNORE.value
+        collection_record.facade_task_id = None
+        collection_record.facade_data_last_collected = now
 
+        collection_record.ml_status = CollectionState.IGNORE.value
+        collection_record.ml_task_id = None
+        collection_record.ml_data_last_collected = now
 
         session.commit()
-        raise RepoGoneException("ERROR: Repo has moved, and there is no redirection! 404 returned, not 301. Resetting Collection!")
 
-    
-    #skip if not 404
+        raise RepoGoneException(
+            "ERROR: Repo has moved, and there is no redirection! "
+            "404 returned, not 301. Resetting Collection!"
+        )
+
+    # --------------------
+    # Repo still exists
+    # --------------------
     logger.info(f"Repo found at url: {url}")
     return
-