Skip to content

Commit 493ddd3

Browse files
committed
feat(build): add cast-to-string for comparisons
It will be safer to use String() rather than depend on the presence of toString() methods on the objects. This is believed to be a non-breaking change.
1 parent 7049f27 commit 493ddd3

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/AureliaDependenciesPlugin.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class ParserPlugin {
4444
parser.plugin("evaluate Identifier imported var.moduleName", (expr: Webpack.MemberExpression) => {
4545
if (expr.property.name === "moduleName" &&
4646
expr.object.name === "PLATFORM" &&
47-
expr.object.type.toString() === "Identifier") {
47+
String(expr.object.type) === "Identifier") {
4848
return new BasicEvaluatedExpression().setIdentifier("PLATFORM.moduleName").setRange(expr.range);
4949
}
5050
return undefined;
@@ -58,8 +58,8 @@ class ParserPlugin {
5858
// PLATFORM.moduleName("id");
5959
parser.plugin("evaluate MemberExpression", (expr: Webpack.MemberExpression) => {
6060
if (expr.property.name === "moduleName" &&
61-
(expr.object.type === "MemberExpression" && expr.object.property.name === "PLATFORM" ||
62-
expr.object.type.toString() === "Identifier" && expr.object.name === "PLATFORM")) {
61+
(String(expr.object.type) === "MemberExpression" && expr.object.property.name === "PLATFORM" ||
62+
String(expr.object.type) === "Identifier" && expr.object.name === "PLATFORM")) {
6363
return new BasicEvaluatedExpression().setIdentifier("PLATFORM.moduleName").setRange(expr.range);
6464
}
6565
return undefined;

0 commit comments

Comments
 (0)