Skip to content

fix: make Windows self-build crashes diagnosable (ANSEL-H)#986

Open
sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/ansel-h-symbolication
Open

fix: make Windows self-build crashes diagnosable (ANSEL-H)#986
sentry[bot] wants to merge 1 commit into
masterfrom
seer/fix/ansel-h-symbolication

Conversation

@sentry

@sentry sentry Bot commented Jul 7, 2026

Copy link
Copy Markdown

This PR addresses issue ANSEL-H ("BaseThreadInitThunk"), where EXCEPTION_ACCESS_VIOLATION crashes on Windows self-builds were undiagnosable due to unresolved debug symbols.

Changes Made:

  1. src/common/sentry.c (Windows DbgHelp Symbol Search Path):

    • Modified the _sentry_capture_windows_backtrace function to explicitly include the executable's directory in the DbgHelp symbol search path. This ensures that PDB files, which are typically located alongside the binaries in self-built environments, are found and used for local symbolication. This should result in windows-backtrace.txt attachments containing resolved function names.
  2. build.sh (Windows/Linux Self-Builds - Optional Sentry Symbol Upload):

    • Added an optional step to build.sh that calls tools/sentry-upload-symbols.sh after the build process. This step is conditional on the SENTRY_AUTH_TOKEN environment variable being set. This allows maintainers or developers with a Sentry token to easily upload debug symbols for their self-builds, enabling server-side symbolication.
  3. packaging/macosx/2_build_hb_ansel_custom.sh (macOS Self-Builds - Optional Sentry Symbol Upload):

    • Implemented the same optional symbol upload logic for macOS self-builds in the Homebrew build script. This provides a consistent mechanism for macOS maintainers to upload DWARF symbols to Sentry.

Rationale:
These changes are crucial for making crashes from self-built versions of Ansel diagnosable. By improving local symbolication on Windows and providing a straightforward way to upload symbols for self-builds across platforms, future crash reports will contain meaningful stack traces. This will enable developers to identify and fix the underlying memory safety issues more effectively.

Fixes ANSEL-H

@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

0 participants