fix: make Windows self-build crashes diagnosable (ANSEL-H)#986
Open
sentry[bot] wants to merge 1 commit into
Open
fix: make Windows self-build crashes diagnosable (ANSEL-H)#986sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR addresses issue ANSEL-H ("BaseThreadInitThunk"), where
EXCEPTION_ACCESS_VIOLATIONcrashes on Windows self-builds were undiagnosable due to unresolved debug symbols.Changes Made:
src/common/sentry.c(Windows DbgHelp Symbol Search Path):_sentry_capture_windows_backtracefunction to explicitly include the executable's directory in the DbgHelp symbol search path. This ensures that PDB files, which are typically located alongside the binaries in self-built environments, are found and used for local symbolication. This should result inwindows-backtrace.txtattachments containing resolved function names.build.sh(Windows/Linux Self-Builds - Optional Sentry Symbol Upload):build.shthat callstools/sentry-upload-symbols.shafter the build process. This step is conditional on theSENTRY_AUTH_TOKENenvironment variable being set. This allows maintainers or developers with a Sentry token to easily upload debug symbols for their self-builds, enabling server-side symbolication.packaging/macosx/2_build_hb_ansel_custom.sh(macOS Self-Builds - Optional Sentry Symbol Upload):Rationale:
These changes are crucial for making crashes from self-built versions of Ansel diagnosable. By improving local symbolication on Windows and providing a straightforward way to upload symbols for self-builds across platforms, future crash reports will contain meaningful stack traces. This will enable developers to identify and fix the underlying memory safety issues more effectively.
Fixes ANSEL-H