Placate Green Hills compiler with ternary#670
Merged
Conversation
When the Green Hills compiler encounters an if/else branch whose predicate is known at compile time, it complains about an unreachable statement. Even if the predicate depends on template parameters (i.e., is not a strict constant _across all template instantiations_), the policy triggers on any _individual_ instantiations that contain an unreachable statement. Leaving aside the wisdom of this policy as it pertains to generic programming, the fact is that we're stuck with it and we need to keep the compiler happy. To fix this instance, we simply use a ternary operator. The ternary is just the same as an if/else branch, but it's a single statement. In testing on AV code, this does seem to placate the Green Hills compiler.
geoffviola
approved these changes
Apr 13, 2026
Contributor
geoffviola
left a comment
geoffviola
left a comment
There was a problem hiding this comment.
The change looks equivalent to what was there before. Hope to see some green hills results soon 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Green Hills compiler encounters an if/else branch whose
predicate is known at compile time, it complains about an unreachable
statement. Even if the predicate depends on template parameters (i.e.,
is not a strict constant across all template instantiations), the
policy triggers on any individual instantiations that contain an
unreachable statement.
Leaving aside the wisdom of this policy as it pertains to generic
programming, the fact is that we're stuck with it and we need to keep
the compiler happy.
To fix this instance, we simply use a ternary operator. The ternary is
just the same as an if/else branch, but it's a single statement. In
testing on AV code, this does seem to placate the Green Hills compiler.