Skip to content

Commit 83dbfdb

Browse files
committed
fix: use Highcharts default values for legend symbol reset
undefined doesn't properly reset merged options. Use the actual Highcharts defaults: symbolWidth:16, symbolHeight:12, symbolPadding:5.
1 parent b9c2825 commit 83dbfdb

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/components/charts/CostBreakdownChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ export function CostBreakdownChart({ stackField = 'model', metricOptions }: Cost
104104
plotOptions: { column: { stacking: 'normal' } },
105105
legend: stackField === 'sku'
106106
? { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 }
107-
: { symbolWidth: undefined, symbolHeight: undefined, symbolPadding: undefined },
107+
: { symbolWidth: 16, symbolHeight: 12, symbolPadding: 5 },
108108
series,
109109
};
110110
}, [activeReport, timeBucket, visibleRows, stackField, activeMetric, dataField]);

src/components/charts/ModelBreakdownChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export function GroupBreakdownChart({ stackField = 'model', metricOptions }: Gro
176176
plotOptions: { bar: { stacking: 'normal' } },
177177
legend: stackField === 'sku'
178178
? { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 }
179-
: { symbolWidth: undefined, symbolHeight: undefined, symbolPadding: undefined },
179+
: { symbolWidth: 16, symbolHeight: 12, symbolPadding: 5 },
180180
series,
181181
};
182182
}, [activeReport, groupByColumn, stackField, visibleRows, hiddenGroups, toggleGroup, activeMetric, dataField]);

src/components/charts/TimeSeriesChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export function TimeSeriesChart({ metricOptions }: { metricOptions?: MetricOptio
182182
series,
183183
legend: groupByColumn === 'sku'
184184
? { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 }
185-
: { symbolWidth: undefined, symbolHeight: undefined, symbolPadding: undefined },
185+
: { symbolWidth: 16, symbolHeight: 12, symbolPadding: 5 },
186186
chart: { height: 400 },
187187
};
188188
}, [activeReport, groupByColumn, timeBucket, visibleRows, lineMode, rollingWindow, dataField, activeMetric]);

0 commit comments

Comments
 (0)