Skip to content

Commit b9c2825

Browse files
committed
fix: explicitly reset legend symbols when switching from SKU to other groupings
Highcharts merges options on update, so symbolWidth:0 persisted when navigating from SKU to user/model. Now always set legend symbol values explicitly (0 for SKU, undefined for others) so Highcharts falls back to its defaults on non-SKU views.
1 parent c783c6f commit b9c2825

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

src/components/charts/CostBreakdownChart.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ export function CostBreakdownChart({ stackField = 'model', metricOptions }: Cost
102102
: '<tr style="border-top: 1px solid var(--borderColor-muted, #d1d9e0b3);"><td><b>Total:&nbsp;</b></td><td style="text-align: right;"><b>{point.total:,.0f}</b></td></tr></table>',
103103
},
104104
plotOptions: { column: { stacking: 'normal' } },
105-
...(stackField === 'sku' && { legend: { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 } }),
105+
legend: stackField === 'sku'
106+
? { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 }
107+
: { symbolWidth: undefined, symbolHeight: undefined, symbolPadding: undefined },
106108
series,
107109
};
108110
}, [activeReport, timeBucket, visibleRows, stackField, activeMetric, dataField]);

src/components/charts/ModelBreakdownChart.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,9 @@ export function GroupBreakdownChart({ stackField = 'model', metricOptions }: Gro
174174
: '<tr style="border-top: 1px solid var(--borderColor-muted, #d1d9e0b3);"><td><b>Total:&nbsp;</b></td><td style="text-align: right;"><b>{point.total:,.0f}</b></td></tr></table>',
175175
},
176176
plotOptions: { bar: { stacking: 'normal' } },
177-
...(stackField === 'sku' && { legend: { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 } }),
177+
legend: stackField === 'sku'
178+
? { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 }
179+
: { symbolWidth: undefined, symbolHeight: undefined, symbolPadding: undefined },
178180
series,
179181
};
180182
}, [activeReport, groupByColumn, stackField, visibleRows, hiddenGroups, toggleGroup, activeMetric, dataField]);

src/components/charts/TimeSeriesChart.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,9 @@ export function TimeSeriesChart({ metricOptions }: { metricOptions?: MetricOptio
180180
},
181181
},
182182
series,
183-
...(groupByColumn === 'sku' && { legend: { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 } }),
183+
legend: groupByColumn === 'sku'
184+
? { symbolWidth: 0, symbolHeight: 0, symbolPadding: 0 }
185+
: { symbolWidth: undefined, symbolHeight: undefined, symbolPadding: undefined },
184186
chart: { height: 400 },
185187
};
186188
}, [activeReport, groupByColumn, timeBucket, visibleRows, lineMode, rollingWindow, dataField, activeMetric]);

0 commit comments

Comments
 (0)