fix: resolve all tsc strict mode errors for CI build

- Add BillingRow type for rows with billing fields (date, grossAmount, etc.)
- Use proper type narrowing in computeSummary with isBillingRow guard
- Cast CSV string values to their literal union types in csv-parser
- Use specific row types instead of Record<string, unknown> in tests
- Chart components narrow to BillingRow since they only handle billing data

Author: austenstone

src/components/charts/CostBreakdownChart.tsx

@@ -7,7 +7,7 @@ import { groupBy, sumBy, timeBucket as bucketRows } from '../../lib/aggregation'
 import { buildColorMap } from '../../lib/chart-theme';
 import { formatDisplayValue, formatCompact, bucketKeyToTimestamp } from '../../lib/formatters';
 import type { MetricOption } from '../../lib/report-schema';
-import type { AnyReportRow } from '../../lib/types';
+import type { AnyReportRow, BillingRow } from '../../lib/types';
 import styles from './Charts.module.css';
 
 interface CostBreakdownChartProps {
@@ -28,7 +28,7 @@ export function CostBreakdownChart({ stackField = 'model', metricOptions }: Cost
   const options = useMemo((): Highcharts.Options | null => {
     if (!activeReport) return null;
 
-    const allRows = visibleRows as AnyReportRow[];
+    const allRows = visibleRows as BillingRow[];
     const rows = activeMetric.rowFilter
       ? allRows.filter((r) => activeMetric.rowFilter!(r as unknown as Record<string, unknown>))
       : allRows;

src/components/charts/TimeSeriesChart.tsx

@@ -8,7 +8,7 @@ import { humanizeColumn, formatDisplayValue, formatCompact, bucketKeyToTimestamp
 import { buildColorMap } from '../../lib/chart-theme';
 import { getStoredValue, setStoredValue, STORAGE_KEYS } from '../../lib/local-storage';
 import type { MetricOption } from '../../lib/report-schema';
-import type { AnyReportRow } from '../../lib/types';
+import type { AnyReportRow, BillingRow } from '../../lib/types';
 import styles from './Charts.module.css';
 
 const LINE_MODES = ['raw', 'rolling', 'cumulative'] as const;
@@ -80,7 +80,7 @@ export function TimeSeriesChart({ metricOptions }: { metricOptions?: MetricOptio
   const options = useMemo((): Highcharts.Options | null => {
     if (!activeReport) return null;
 
-    const allRows = visibleRows as AnyReportRow[];
+    const allRows = visibleRows as BillingRow[];
     const rows = activeMetric.rowFilter
       ? allRows.filter((r) => activeMetric.rowFilter!(r as unknown as Record<string, unknown>))
       : allRows;

src/lib/aggregation.ts

@@ -1,4 +1,4 @@
-import type { AnyReportRow, TimeBucket, ReportSummary } from './types';
+import type { AnyReportRow, BillingRow, TimeBucket, ReportSummary, UsageReportRow, TokenUsageRow } from './types';
 
 /** Group rows by a column value, returning a map of group key → rows */
 export function groupBy<T extends AnyReportRow>(
@@ -53,7 +53,7 @@ export function getTimeBucketKey(dateStr: string, bucket: TimeBucket): string {
 }
 
 /** Group rows by time bucket, returning sorted entries */
-export function timeBucket<T extends AnyReportRow>(
+export function timeBucket<T extends BillingRow>(
   rows: T[],
   bucket: TimeBucket,
 ): Map<string, T[]> {
@@ -92,9 +92,15 @@ export function topN<T extends AnyReportRow>(
   return ranked.slice(0, n);
 }
 
+/** Type guard for rows with billing fields */
+function isBillingRow(row: AnyReportRow): row is BillingRow {
+  return 'date' in row && 'grossAmount' in row;
+}
+
 /** Compute summary metrics for a set of rows */
 export function computeSummary(rows: AnyReportRow[]): ReportSummary {
-  const dates = rows.map((r) => r.date).filter(Boolean).sort();
+  const billingRows = rows.filter(isBillingRow);
+  const dates = billingRows.map((r) => r.date).filter(Boolean).sort();
   const users = new Set<string>();
   const organizations = new Set<string>();
   const models = new Set<string>();
@@ -109,30 +115,31 @@ export function computeSummary(rows: AnyReportRow[]): ReportSummary {
   let totalStorageGBH = 0;
   let totalTokens = 0;
 
-  for (const row of rows) {
+  for (const row of billingRows) {
     totalGrossAmount += row.grossAmount;
     totalNetAmount += row.netAmount;
     totalDiscountAmount += row.discountAmount;
     totalQuantity += row.quantity;
 
-    if ('username' in row && row.username) users.add(row.username as string);
-    if ('organization' in row && row.organization) organizations.add(row.organization as string);
-    if ('model' in row && row.model) models.add(row.model as string);
-    if ('repository' in row && (row as Record<string, unknown>).repository) repositories.add((row as Record<string, unknown>).repository as string);
-    if ('product' in row && (row as Record<string, unknown>).product) products.add((row as Record<string, unknown>).product as string);
+    if ('username' in row && row.username) users.add(row.username);
+    if ('organization' in row && row.organization) organizations.add(row.organization);
+    if ('model' in row) models.add(row.model);
+    const usageRow = row as UsageReportRow;
+    if ('repository' in row && usageRow.repository) repositories.add(usageRow.repository);
+    if ('product' in row && row.product) products.add(String(row.product));
 
-    // Accumulate unit-type-specific totals
+    // Accumulate unit-type-specific totals for usage reports
     if ('unitType' in row) {
-      const unitType = (row as Record<string, unknown>).unitType;
-      if (unitType === 'minutes') totalMinutes += row.quantity;
-      if (unitType === 'gigabyte-hours') totalStorageGBH += row.quantity;
+      const u = row as UsageReportRow;
+      if (u.unitType === 'minutes') totalMinutes += u.quantity;
+      if (u.unitType === 'gigabyte-hours') totalStorageGBH += u.quantity;
     }
 
     // Accumulate token totals
     if ('totalInputTokens' in row) {
-      const r = row as Record<string, number>;
-      totalTokens += (r.totalInputTokens ?? 0) + (r.totalOutputTokens ?? 0)
-        + (r.totalCacheCreationTokens ?? 0) + (r.totalCacheReadTokens ?? 0);
+      const t = row as TokenUsageRow;
+      totalTokens += (t.totalInputTokens ?? 0) + (t.totalOutputTokens ?? 0)
+        + (t.totalCacheCreationTokens ?? 0) + (t.totalCacheReadTokens ?? 0);
     }
   }
 

src/lib/csv-parser.test.ts

@@ -323,7 +323,7 @@ describe('parseCSV — Token Usage (real file)', () => {
 
   it('does NOT have aicQuantity or aicGrossAmount fields', () => {
     const report = parseCSV(csv, 'Token.Usage.Report.csv');
-    const row = report.rows[0] as Record<string, unknown>;
+    const row = report.rows[0] as TokenUsageRow;
     expect(row).not.toHaveProperty('aicQuantity');
     expect(row).not.toHaveProperty('aicGrossAmount');
   });
@@ -523,7 +523,7 @@ describe('parseCSV — GHAS Active Committers (real file)', () => {
 
   it('does NOT have billing columns (no grossAmount, netAmount, etc.)', () => {
     const report = parseCSV(csv, 'ghas.csv');
-    const row = report.rows[0] as Record<string, unknown>;
+    const row = report.rows[0] as GhasActiveCommittersRow;
     expect(row).not.toHaveProperty('grossAmount');
     expect(row).not.toHaveProperty('netAmount');
     expect(row).not.toHaveProperty('quantity');
@@ -567,7 +567,7 @@ describe('cross-report schema validation', () => {
   it('token usage has token fields that premium request lacks', () => {
     const tuCsv = loadExample('Token.Usage.Report.csv');
     const tuReport = parseCSV(tuCsv, 'tu.csv');
-    const tuRow = tuReport.rows[0] as Record<string, unknown>;
+    const tuRow = tuReport.rows[0] as TokenUsageRow;
 
     expect(tuRow).toHaveProperty('totalInputTokens');
     expect(tuRow).toHaveProperty('totalOutputTokens');
@@ -579,7 +579,7 @@ describe('cross-report schema validation', () => {
   it('premium request has AIC fields that token usage lacks', () => {
     const prCsv = loadExample('premiumRequestUsageReport_1_c6fca30f0acd458098a95808eaf43399.csv');
     const prReport = parseCSV(prCsv, 'pr.csv');
-    const prRow = prReport.rows[0] as Record<string, unknown>;
+    const prRow = prReport.rows[0] as PremiumRequestRow;
 
     expect(prRow).toHaveProperty('aicQuantity');
     expect(prRow).toHaveProperty('aicGrossAmount');

src/lib/csv-parser.ts

@@ -6,6 +6,10 @@ import type {
   GhasActiveCommittersRow,
   ParsedReport,
   ReportType,
+  CopilotProduct,
+  PremiumRequestSku,
+  UsageProduct,
+  UsageUnitType,
 } from './types';
 import { REPORT_TYPES } from './types';
 
@@ -47,11 +51,11 @@ function mapPremiumRequestRow(raw: Record<string, string>): PremiumRequestRow {
   return {
     date: raw['date'] ?? '',
     username: raw['username'] ?? '',
-    product: raw['product'] ?? '',
-    sku: raw['sku'] ?? '',
+    product: (raw['product'] ?? '') as CopilotProduct,
+    sku: (raw['sku'] ?? '') as PremiumRequestSku,
     model: raw['model'] ?? '',
     quantity: parseNum(raw['quantity']),
-    unitType: raw['unit_type'] ?? '',
+    unitType: (raw['unit_type'] ?? '') as 'requests' | 'ai-units',
     appliedCostPerQuantity: parseNum(raw['applied_cost_per_quantity']),
     grossAmount: parseNum(raw['gross_amount']),
     discountAmount: parseNum(raw['discount_amount']),
@@ -70,11 +74,11 @@ function mapTokenUsageRow(raw: Record<string, string>): TokenUsageRow {
   return {
     date: raw['date'] ?? '',
     username: raw['username'] ?? '',
-    product: raw['product'] ?? '',
-    sku: raw['sku'] ?? '',
+    product: (raw['product'] ?? '') as CopilotProduct,
+    sku: (raw['sku'] ?? '') as PremiumRequestSku,
     model: raw['model'] ?? '',
     quantity: parseNum(raw['quantity']),
-    unitType: raw['unit_type'] ?? '',
+    unitType: (raw['unit_type'] ?? '') as 'requests' | 'ai-units',
     appliedCostPerQuantity: parseNum(raw['applied_cost_per_quantity']),
     grossAmount: parseNum(raw['gross_amount']),
     discountAmount: parseNum(raw['discount_amount']),
@@ -94,10 +98,10 @@ function mapTokenUsageRow(raw: Record<string, string>): TokenUsageRow {
 function mapUsageReportRow(raw: Record<string, string>): UsageReportRow {
   return {
     date: raw['date'] ?? '',
-    product: raw['product'] ?? '',
+    product: (raw['product'] ?? '') as UsageProduct,
     sku: raw['sku'] ?? '',
     quantity: parseNum(raw['quantity']),
-    unitType: raw['unit_type'] ?? '',
+    unitType: (raw['unit_type'] ?? '') as UsageUnitType,
     appliedCostPerQuantity: parseNum(raw['applied_cost_per_quantity']),
     grossAmount: parseNum(raw['gross_amount']),
     discountAmount: parseNum(raw['discount_amount']),

src/lib/types.ts

@@ -170,8 +170,7 @@ export type GhasActiveCommittersCsvHeader =
 // ─── Parsed Row Interfaces ─────────────────────────────────────────────────────
 
 /** Shared columns across Premium Request and Token Usage reports */
-interface BaseCopilotReportRow {
-  /** ISO date string (YYYY-MM-DD) */
+interface BaseCopilotReportRow {  /** ISO date string (YYYY-MM-DD) */
   date: string;
   /** GitHub username */
   username: string;
@@ -224,8 +223,7 @@ export interface TokenUsageRow extends BaseCopilotReportRow {
 }
 
 /** General Usage Report row (Actions, Copilot seats, LFS, Packages) */
-export interface UsageReportRow {
-  /** ISO date string (YYYY-MM-DD), first of month */
+export interface UsageReportRow {  /** ISO date string (YYYY-MM-DD), first of month */
   date: string;
   /** Product category */
   product: UsageProduct;
@@ -256,8 +254,7 @@ export interface UsageReportRow {
 }
 
 /** GHAS Active Committers report row */
-export interface GhasActiveCommittersRow {
-  /** GitHub username */
+export interface GhasActiveCommittersRow {  /** GitHub username */
   userLogin: string;
   /** Combined "org/repo" string that needs splitting for org vs repo */
   organizationRepository: string;
@@ -286,7 +283,10 @@ export interface ParsedReport<T = PremiumRequestRow | TokenUsageRow | UsageRepor
   dateRange: { start: string; end: string };
 }
 
-export type AnyReportRow = PremiumRequestRow | TokenUsageRow | UsageReportRow | GhasActiveCommittersRow;
+/** Report rows that have billing fields (date, grossAmount, netAmount, etc.) */
+export type BillingRow = PremiumRequestRow | TokenUsageRow | UsageReportRow;
+
+export type AnyReportRow = BillingRow | GhasActiveCommittersRow;
 
 /** Groupable columns vary by report type */
 export const GROUPABLE_COLUMNS = {