Add to CustomTabsOptions ability to disable opening auth in custom tab#806
Merged
pmathew92 merged 4 commits intoauth0:mainfrom Mar 6, 2025
Merged
Add to CustomTabsOptions ability to disable opening auth in custom tab#806pmathew92 merged 4 commits intoauth0:mainfrom
pmathew92 merged 4 commits intoauth0:mainfrom
Conversation
bennycao
commented
Mar 4, 2025
auth0/src/main/java/com/auth0/android/provider/CustomTabsOptions.java
Outdated
Show resolved
Hide resolved
Contributor
|
Hi @bennycao , |
5 tasks
pmathew92
previously approved these changes
Mar 6, 2025
pmathew92
reviewed
Mar 6, 2025
Contributor
pmathew92
left a comment
There was a problem hiding this comment.
Thank you for raising this PR . Few minor changes .Please address them and we should be good to merge this
pmathew92
reviewed
Mar 6, 2025
Contributor
Author
@pmathew92 thank you, i've addressed most of your comments. Just one about extra lines which i'm not too sure about it |
pmathew92
approved these changes
Mar 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add option in
CustomTabsOptionsto define a list of browser packages where you do not want to launch the authentication url in custom tab. This adds feature #805 to solve incompatible custom tab browser.Please describe both what is changing and why this is important. Include:
withDisabledCustomTabsPackagesto define list of custom tab packages to disable which assigns to new instance variabledisabledCustomTabsPackagesCustomTabOptions.toIntentto getpreferredPackagewhich is the preferred browser package calculated by browser picker.CustomTabOptions.toIntentto validate if thepreferredPackageis in thedisabledCustomTabsPackageslist, and if so, just returnIntentwith action ofIntent.ACTION_VIEWonlyReferences
solves feature #805
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors