Conversation
pmathew92
reviewed
Apr 23, 2025
| * | ||
| * @return The URL to call to perform the web flow of OAuth. | ||
| */ | ||
| public open fun buildAuthorizeUrl(): String { // Function instead of property |
Contributor
There was a problem hiding this comment.
This will work only for clients who would be extending the Auth0 class. Most use cases would only be creating an instance of the existing class and will not be extending them. This won't work for the majority use case
pmathew92
requested changes
Apr 23, 2025
Contributor
pmathew92
left a comment
pmathew92
left a comment
There was a problem hiding this comment.
This implementation won't work for majority use case of creating an Auth0 instance .
pmathew92
reviewed
Apr 28, 2025
| .withScheme(getString(R.string.com_auth0_scheme)) | ||
| .withAudience(audience) | ||
| .withScope(scope) | ||
| .withAuthorizeUrl(customAuthorizeUrl) |
Contributor
There was a problem hiding this comment.
No need to add in the sample app
pmathew92
reviewed
Apr 28, 2025
| try { | ||
| WebAuthProvider.logout(account) | ||
| .withScheme(getString(R.string.com_auth0_scheme)) | ||
| .withLogoutUrl(customLogoutUrl) |
Contributor
There was a problem hiding this comment.
No need to add in the sample app
pmathew92
reviewed
Apr 28, 2025
| parameters = state.parameters, | ||
| callback = callback | ||
| callback = callback, | ||
| customAuthorizeUrl = null |
Contributor
There was a problem hiding this comment.
Please add the customAuthorizeUrl in the fromState method and updated the UT to cover it
pmathew92
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
-Added buildAuthorizeUrl() and buildLogoutUrl() so that logoutUrl and authorizeUrl can be overidden.
Auth0.kt
References
Please include relevant links supporting this change such as a:
#816
Testing
Unit Test cases to check if methods can be accessed in Unit Test file Auth0Test.java
[yes] This change adds unit test coverage
[yes] This change adds integration test coverage
[yes] This change has been tested on the latest version of the platform/language or why not
Checklist
[yes] I have read the Auth0 general contribution guidelines
[yes] I have read the Auth0 Code of Conduct
[yes] All existing and new tests complete without errors