Conversation
|
FYI the SDK already supports passing arbitrary parameters to any request: https://github.com/auth0/Auth0.Android/blob/3.8.0/auth0/src/main/java/com/auth0/android/request/Request.kt#L57 |
|
If you prefer to add an explicit argument for this, consider adding the argument to all the other (relevant) methods of the Authentication API client. |
The idea was to explicitly say that a user can be added to an org while signing up and signing in with passkeys. Hence added to only these two api end points. I am aware ,we can add it as an additional parameter to the request object, but felt this would be more clearer with the intention. If that is not required, there is no additional changes required on SDKs and we just needs to call this out in the docs |
Sounds good 👍🏼 |
| @@ -304,7 +310,8 @@ public class AuthenticationAPIClient @VisibleForTesting(otherwise = VisibleForTe | |||
| * @return a request to configure and start that will yield [PasskeyChallenge] | |||
There was a problem hiding this comment.
The doc comments should mention the new argument here as well.
There was a problem hiding this comment.
This was accidentally missed. Updated the same
This PR lets user to be added to a organization while signing up or signing in with a passkey
Testing
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors