feat: add connected accounts callback handling#817
Merged
yogeshchoudhary147 merged 4 commits intomainfrom Feb 25, 2026
Merged
Conversation
yogeshchoudhary147
force-pushed
the
feat/connected-accounts-callback-handling
branch
5 times, most recently
from
8f3a71e to
4b86caa
Compare
- Add ConnectedAccount type and update AppState interface - Export ResponseType, ConnectError, and ConnectAccountRedirectResult - Update handleRedirectCallback to extract connected account data - Add connect_code parameter detection in shouldHandleCallback - Add comprehensive test coverage for callback handling - Update documentation with connected accounts usage examples
yogeshchoudhary147
force-pushed
the
feat/connected-accounts-callback-handling
branch
from
4b86caa to
d63825a
Compare
| appState.connectedAccount = rest as ConnectedAccount; | ||
| } | ||
|
|
||
| if (appState) { |
Contributor
There was a problem hiding this comment.
@yogeshchoudhary147 On line number 398, we have added
appState.response_type = response_type;
This will always make the appState always truthy, even for non-connected account flow.
Will that not cause side effects ?
Contributor
Author
There was a problem hiding this comment.
Good catch! Removed the {} default so we no longer emit to appState$ when no appState was provided in a regular login flow.
gyaneshgouraw-okta
approved these changes
Feb 25, 2026
yogeshchoudhary147
deleted the
feat/connected-accounts-callback-handling
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-02-21.at.6.04.32.PM.mov
Description
Completes the Connected Accounts implementation started in #767. Previously the SDK could initiate the connect flow but couldn't process the response when users returned from connecting their account. This PR adds the missing callback logic.
Changes
appState$after redirect completesConnectedAccount,ResponseType,ConnectError,ConnectAccountRedirectResultNote
The SPA SDK's role in Token Vault covers the Connected Accounts flow: initiating and completing account connections and managing them via the My Account API. Actual token retrieval from Token Vault requires a confidential backend client.
Testing
4 new tests added, 131 total passing. E2E flow verified (see demo above).