Skip to content

fix(security): run npm ci with --ignore-scripts#893

Closed
jcchavezs wants to merge 2 commits intoauth0:mainfrom
jcchavezs:ci_ignore_scripts
Closed

fix(security): run npm ci with --ignore-scripts#893
jcchavezs wants to merge 2 commits intoauth0:mainfrom
jcchavezs:ci_ignore_scripts

Conversation

@jcchavezs
Copy link
Copy Markdown

This would avoid malicious scripts in vulnerable packages to be executed on CI

@yogeshchoudhary147
Copy link
Copy Markdown
Contributor

Thanks for the contribution! This makes sense for hardening our CI pipeline against supply chain attacks.

Could you also add --ignore-scripts to the other two npm ci calls that were missed?

  1. .github/actions/build/action.yml (line 21)
  2. .github/actions/npm-publish/action.yml (line 33 — npm ci --include=devnpm ci --include=dev --ignore-scripts)

That way we're consistent across the entire CI surface.

@yogeshchoudhary147
Copy link
Copy Markdown
Contributor

Closing in favour of #897 which adds ignore-scripts=true via .npmrc, covering all npm install invocations rather than just CI steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants