fix: lint fixes

Author: KartikJha

internal/ai/skills/fs_util.go

@@ -22,7 +22,7 @@ func mergeDir(src, dst string) error {
 			if err != nil {
 				return err
 			}
-			// os.Symlink is not idempotent (returns EEXIST). Remove any existing
+			// Os.Symlink is not idempotent (returns EEXIST). Remove any existing
 			// entry so the call is safe under concurrent writes or repeated merges.
 			_ = os.Remove(dstPath)
 			if err := os.Symlink(target, dstPath); err != nil {

internal/ai/skills/symlink.go

@@ -13,7 +13,7 @@ import (
 var stderrWriter io.Writer = os.Stderr
 
 // CreateSkillLink installs skillName from sourceSkillDir into agentSkillsDir.
-// useCopy=true copies files recursively; useCopy=false creates a symlink.
+// When useCopy is true the directory is copied recursively; otherwise a symlink is created.
 // The operation is idempotent: a correct existing symlink or copy is left unchanged.
 func CreateSkillLink(sourceSkillDir, agentSkillsDir, skillName string, useCopy bool) error {
 	if err := os.MkdirAll(agentSkillsDir, 0o755); err != nil {
@@ -24,7 +24,8 @@ func CreateSkillLink(sourceSkillDir, agentSkillsDir, skillName string, useCopy b
 
 	info, err := os.Lstat(linkPath)
 	if err == nil {
-		if info.Mode()&os.ModeSymlink != 0 {
+		switch {
+		case info.Mode()&os.ModeSymlink != 0:
 			// For useCopy=false: skip if already pointing to the right place.
 			// For useCopy=true: remove the symlink so we can replace it with a copy.
 			if !useCopy && isSymlinkCorrect(linkPath, sourceSkillDir) {
@@ -33,15 +34,15 @@ func CreateSkillLink(sourceSkillDir, agentSkillsDir, skillName string, useCopy b
 			if rmErr := os.Remove(linkPath); rmErr != nil {
 				return fmt.Errorf("remove existing symlink %s: %w", linkPath, rmErr)
 			}
-		} else if info.IsDir() {
+		case info.IsDir():
 			if !useCopy {
 				fmt.Fprintf(stderrWriter,
 					"warning: %s is a copied directory; remove it manually to switch to symlink mode\n",
 					linkPath)
 				return nil
 			}
-			// useCopy=true: fall through to re-copy with replace semantics.
-		} else {
+			// UseCopy=true: fall through to re-copy with replace semantics.
+		default:
 			return fmt.Errorf("%s exists as a regular file; remove it before installing skill %q", linkPath, skillName)
 		}
 	} else if !os.IsNotExist(err) {
@@ -55,11 +56,11 @@ func CreateSkillLink(sourceSkillDir, agentSkillsDir, skillName string, useCopy b
 }
 
 // isSymlinkCorrect returns true if linkPath is a non-broken symlink resolving to sourceSkillDir.
-// os.SameFile is used instead of string comparison to handle case-insensitive filesystems (e.g. macOS APFS).
+// Uses os.SameFile instead of string comparison to handle case-insensitive filesystems (e.g. macOS APFS).
 func isSymlinkCorrect(linkPath, sourceSkillDir string) bool {
 	linkInfo, err := os.Stat(linkPath)
 	if err != nil {
-		return false // broken symlink
+		return false // Broken symlink.
 	}
 	srcInfo, err := os.Stat(sourceSkillDir)
 	if err != nil {
@@ -123,7 +124,7 @@ func copyDir(src, dst string) error {
 			return mergeErr
 		}
 	} else {
-		tmpRemoved = true // rename succeeded; temp dir is now dst
+		tmpRemoved = true // Rename succeeded; temp dir is now dst.
 	}
 	return nil
 }

internal/ai/skills/symlink_test.go

@@ -30,7 +30,7 @@ func makeSkillSource(t *testing.T) string {
 	return dir
 }
 
-// --- CheckSkillLink ---
+// --- CheckSkillLink ---.
 
 func TestCheckSkillLink(t *testing.T) {
 	if runtime.GOOS == "windows" {
@@ -102,7 +102,7 @@ func TestCheckSkillLink(t *testing.T) {
 	})
 }
 
-// --- CreateSkillLink ---
+// --- CreateSkillLink ---.
 
 func TestCreateSkillLink(t *testing.T) {
 	if runtime.GOOS == "windows" {
@@ -265,10 +265,9 @@ func TestCreateSkillLink(t *testing.T) {
 		require.NoError(t, err)
 		assert.Equal(t, "# skill", string(data))
 	})
-
 }
 
-// --- RemoveSkillLink ---
+// --- RemoveSkillLink ---.
 
 func TestRemoveSkillLink(t *testing.T) {
 	if runtime.GOOS == "windows" {

internal/ai/skills/validate.go

@@ -11,12 +11,12 @@ type SkillInstallStatus struct {
 	SkillName string
 	AgentID   string
 	LinkPath  string
-	Status    string // "ok" | "missing" | "broken_symlink" | "invalid_skill" | "copy" | "unknown"
+	Status    string // "ok" | "missing" | "broken_symlink" | "invalid_skill" | "copy" | "unknown".
 	Error     string
 }
 
-// ValidateInstall checks each skill in skills for the given agent.
-// sourcePluginDir is the directory containing skill subdirectories (pluginDir/skills/).
+// ValidateInstall checks the installation state of each skill in agentSkillsDir.
+// The sourcePluginDir parameter is the directory containing skill subdirectories (pluginDir/skills/).
 func ValidateInstall(agentID, agentSkillsDir, sourcePluginDir string, skills []string) []SkillInstallStatus {
 	out := make([]SkillInstallStatus, 0, len(skills))
 	for _, skillName := range skills {

internal/ai/skills/validate_test.go

@@ -196,7 +196,7 @@ func TestValidateInstall_MultipleSkills(t *testing.T) {
 	if err := CreateSkillLink(filepath.Join(sourcePluginDir, "skill-a"), agentSkillsDir, "skill-a", false); err != nil {
 		t.Fatal(err)
 	}
-	// skill-b intentionally not installed.
+	// Skill-b intentionally not installed.
 
 	statuses := ValidateInstall("claude-code", agentSkillsDir, sourcePluginDir, []string{"skill-a", "skill-b"})
 	if len(statuses) != 2 {
@@ -240,7 +240,7 @@ func TestValidateInstall_EmptySkillsList(t *testing.T) {
 func TestValidateInstall_AbsentAgentSkillsDir(t *testing.T) {
 	tmp := t.TempDir()
 	sourcePluginDir := filepath.Join(tmp, "plugins")
-	// agentSkillsDir does not exist — all requested skills should return "missing".
+	// AgentSkillsDir does not exist — all requested skills should return "missing".
 	agentSkillsDir := filepath.Join(tmp, "nonexistent", "agent", "skills")
 
 	statuses := ValidateInstall("claude-code", agentSkillsDir, sourcePluginDir, []string{"auth0-react", "auth0-nextjs"})