-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Swift Package Manager dependency support for Flutter iOS/macOS SDK #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
8030a40
532463a
55b171a
db2d291
30dcb24
08ae73f
31445aa
726ce4a
03e8c8b
a6a2259
87fad29
a997fff
abc3814
f0c1048
33056a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,6 @@ concurrency: | |
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | ||
|
|
||
| env: | ||
| ruby: '3.3.1' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ruby was primarily added cocoapods support. Github actions are updated to support swift package manager |
||
| flutter: '3.x' | ||
| ios-simulator: iPhone 16 | ||
| java: 17 | ||
|
|
@@ -139,7 +138,6 @@ jobs: | |
| uses: ./.github/actions/setup-darwin | ||
| with: | ||
| platform: ${{ env.platform }} | ||
| ruby: ${{ env.ruby }} | ||
| flutter: ${{ env.flutter }} | ||
| xcode: ${{ matrix.xcode }} | ||
| auth0-domain: ${{ vars.AUTH0_DOMAIN }} | ||
|
|
@@ -151,15 +149,21 @@ jobs: | |
| platform: ${{ env.platform }} | ||
| destination: ${{ format('{0}{1}', 'platform=iOS Simulator,name=', env.ios-simulator) }} | ||
|
|
||
| - name: Convert coverage report | ||
| # Codecov cannot parse a raw .xcresult bundle, so convert it to | ||
| # Cobertura XML first. xcresultparser is Ruby-free, keeping the SPM | ||
| # migration's goal of dropping the Ruby/slather toolchain. | ||
| - name: Convert xcresult to Cobertura coverage | ||
| working-directory: auth0_flutter/example/ios | ||
| run: bundle exec slather coverage -x --scheme Runner Runner.xcodeproj | ||
| run: | | ||
| brew install a7ex/homebrew-formulae/xcresultparser | ||
| xcresultparser --output-format cobertura unit-tests.xcresult > coverage.xml | ||
| shell: bash | ||
|
|
||
| - name: Upload coverage report | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: iOS coverage | ||
| path: auth0_flutter/example/ios/cobertura | ||
| path: auth0_flutter/example/ios/coverage.xml | ||
| # TODO: fix both android and iOS smoke testcases and uncomment them. | ||
| # test-ios-smoke: | ||
| # name: Run native iOS smoke tests using Xcode ${{ matrix.xcode }} | ||
|
|
@@ -217,7 +221,6 @@ jobs: | |
| uses: ./.github/actions/setup-darwin | ||
| with: | ||
| platform: ${{ env.platform }} | ||
| ruby: ${{ env.ruby }} | ||
| flutter: ${{ env.flutter }} | ||
| xcode: ${{ matrix.xcode }} | ||
| auth0-domain: ${{ vars.AUTH0_DOMAIN }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,7 @@ coverage/ | |
| appium-test/node_modules/* | ||
|
|
||
| .idea/* | ||
|
|
||
| # Swift Package Manager | ||
| .build/ | ||
| .swiftpm/ | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../auth0_flutter/Sources/auth0_flutter/AuthAPI/AuthAPICustomTokenExchangeMethodHandler.swift |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../auth0_flutter/Sources/auth0_flutter/AuthAPI/AuthAPIEmailPasswordlessLoginMethodHandler.swift |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../auth0_flutter/Sources/auth0_flutter/AuthAPI/AuthAPIExtensions.swift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use normalized platform output in conditional gates.
Line 55 and Line 66 compare
inputs.platformcase-sensitively;ios/macosinputs would skip the deployment-target patch and can reintroduce platform mismatch failures. Reuse the normalized value fromlowercase-platform.Suggested fix
🤖 Prompt for AI Agents