refactor: Move darwin native sources into a canonical Sources/ tree#892
refactor: Move darwin native sources into a canonical Sources/ tree#892NandanPrabhu wants to merge 1 commit into
Conversation
Relocates auth0_flutter/darwin/Classes/*.swift into auth0_flutter/darwin/auth0_flutter/Sources/auth0_flutter/, turning the old Classes/ location (and the ios/ and macos/ CocoaPods dirs) into symlinks generated by scripts/generate-symlinks.sh. This gives CocoaPods and a future SPM target a single canonical source location instead of duplicated/symlinked per-platform trees. Also renames SwiftAuth0FlutterPlugin -> Auth0FlutterPlugin and drops the Objective-C shim (Auth0FlutterPlugin.h/.m), since the class name can now match the pluginClass declared in pubspec.yaml directly without an ObjC bridge. Pure move: every relocated file is byte-identical to its previous location.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing and reopening as a fresh PR to keep this cascading pair's PR numbers/descriptions in sync (see the SPM PR it now precedes: #893). |
📋 Changes
Extracted from #804. Relocates
auth0_flutter/darwin/Classes/*.swiftintoauth0_flutter/darwin/auth0_flutter/Sources/auth0_flutter/, turning the oldClasses/location — and theios//macos/CocoaPods directories — into symlinks generated byscripts/generate-symlinks.sh. This gives CocoaPods (and a future SPM target) a single canonical source location instead of duplicated/symlinked per-platform trees.Also renames
SwiftAuth0FlutterPlugin→Auth0FlutterPluginand drops the Objective-C shim (Auth0FlutterPlugin.h/.m), since the class name can now match thepluginClassdeclared inpubspec.yamldirectly without an ObjC bridge.This is a pure move + rename, no behavior change for CocoaPods consumers:
main).darwin/auth0_flutter.podspec'ssource_filesis updated to point at the new path;ios/andmacos/podspecs are unchanged (they still globClasses/**/*, which is now populated by regenerated symlinks).scripts/generate-symlinks.shis updated to generatedarwin/Classes/<rel> -> ../../auth0_flutter/Sources/auth0_flutter/<rel>andios|macos/Classes/<rel> -> ../../../darwin/Classes/<rel>, verifying every symlink resolves. Confirmed idempotent (re-running the script against its own output produces no diff), so the existingSymlinksCI job continues to pass.No Dart files,
pubspec.yaml, or CI workflows are touched.📎 References
🎯 Testing
darwin/Classes/is byte-identical to itsmaincounterpart (2 intentional exceptions: the plugin class rename and dropping the ObjC shim).pod ipc spec auth0_flutter/darwin/auth0_flutter.podspecvalidates the podspec and resolvessource_filesto the 64 real Swift files under the newSources/path.scripts/generate-symlinks.shafter committing; zero diff, confirming CI'sSymlinkscheck will pass.plutil -linton the updated example iOSproject.pbxprojafter the test-file rename.🤖 Generated with Claude Code