Skip to content

Commit 6a8fa87

Browse files
Move phone number checking out of common method
1 parent f8c1dfd commit 6a8fa87

1 file changed

Lines changed: 13 additions & 6 deletions

File tree

src/main/java/com/auth0/client/auth/AuthAPI.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1395,7 +1395,8 @@ public Request<CreatedOtpResponse> addOtpAuthenticator(String mfaToken) {
13951395
return request;
13961396
}
13971397

1398-
private BaseRequest<CreatedOobResponse> createBaseOobRequest(String mfaToken, List<String> oobChannels, String phoneNumber) {
1398+
1399+
private BaseRequest<CreatedOobResponse> createBaseOobRequest(String mfaToken, List<String> oobChannels) {
13991400
Asserts.assertNotNull(mfaToken, "mfa token");
14001401
Asserts.assertNotNull(oobChannels, "OOB channels");
14011402

@@ -1412,9 +1413,6 @@ private BaseRequest<CreatedOobResponse> createBaseOobRequest(String mfaToken, Li
14121413
request.addParameter("authenticator_types", Collections.singletonList("oob"));
14131414
request.addParameter("oob_channels", oobChannels);
14141415
request.addParameter(KEY_CLIENT_ID, clientId);
1415-
if (phoneNumber != null) {
1416-
request.addParameter("phone_number", phoneNumber);
1417-
}
14181416
addClientAuthentication(request, false);
14191417
request.addHeader("Authorization", "Bearer " + mfaToken);
14201418

@@ -1445,7 +1443,12 @@ private BaseRequest<CreatedOobResponse> createBaseOobRequest(String mfaToken, Li
14451443
*/
14461444
@Deprecated
14471445
public Request<CreatedOobResponse> addOobAuthenticator(String mfaToken, List<String> oobChannels, String phoneNumber) {
1448-
return createBaseOobRequest(mfaToken, oobChannels, phoneNumber);
1446+
BaseRequest<CreatedOobResponse> request = createBaseOobRequest(mfaToken, oobChannels);
1447+
if (phoneNumber != null) {
1448+
request.addParameter("phone_number", phoneNumber);
1449+
}
1450+
1451+
return request;
14491452
}
14501453

14511454
/**
@@ -1478,10 +1481,14 @@ public Request<CreatedOobResponse> addOobAuthenticator(String mfaToken, List<Str
14781481
Asserts.assertNotNull(emailAddress, "email address");
14791482
}
14801483

1481-
BaseRequest<CreatedOobResponse> request = createBaseOobRequest(mfaToken, oobChannels, phoneNumber);
1484+
BaseRequest<CreatedOobResponse> request = createBaseOobRequest(mfaToken, oobChannels);
1485+
if (phoneNumber != null) {
1486+
request.addParameter("phone_number", phoneNumber);
1487+
}
14821488
if (emailAddress != null) {
14831489
request.addParameter("email", emailAddress);
14841490
}
1491+
14851492
return request;
14861493
}
14871494

0 commit comments

Comments
 (0)