More test coverage

Author: JoaoSouMoreira

src/test/java/com/auth0/client/auth/AuthAPITest.java

@@ -1565,6 +1565,14 @@ public void addOobAuthenticatorDeprecatedThrowsWhenPhoneNumberNull() {
             "'phone number' cannot be null!");
     }
 
+    @SuppressWarnings("deprecation")
+    @Test
+    public void addOobAuthenticatorDeprecatedThrowsWhenPhoneNumberNullVoiceChannel() {
+        verifyThrows(IllegalArgumentException.class,
+            () -> api.addOobAuthenticator("mfaToken", Collections.singletonList("voice"), null),
+            "'phone number' cannot be null!");
+    }
+
     @SuppressWarnings("deprecation")
     @Test
     public void addOobAuthenticatorDeprecatedRequest() throws Exception {
@@ -1590,6 +1598,30 @@ public void addOobAuthenticatorDeprecatedRequest() throws Exception {
         assertThat(response.getRecoveryCodes(), notNullValue());
     }
 
+    @SuppressWarnings("deprecation")
+    @Test
+    public void addOobAuthenticatorDeprecatedRequestWithNoPhoneNumber() throws Exception {
+        Request<CreatedOobResponse> request = api.addOobAuthenticator("mfaToken", Collections.singletonList("auth0"), null);
+
+        server.jsonResponse(AUTH_OOB_AUTHENTICATOR_RESPONSE, 200);
+        CreatedOobResponse response = request.execute().getBody();
+        RecordedRequest recordedRequest = server.takeRequest();
+
+        assertThat(recordedRequest, hasMethodAndPath(HttpMethod.POST, "/mfa/associate"));
+        assertThat(recordedRequest, hasHeader("Content-Type", "application/json"));
+
+        Map<String, Object> body = bodyFromRequest(recordedRequest);
+        assertThat(body, hasEntry("authenticator_types", Collections.singletonList("oob")));
+        assertThat(body, hasEntry("oob_channels", Collections.singletonList("auth0")));
+
+        assertThat(response, is(notNullValue()));
+        assertThat(response.getAuthenticatorType(), not(emptyOrNullString()));
+        assertThat(response.getOobChannel(), not(emptyOrNullString()));
+        assertThat(response.getOobCode(), not(emptyOrNullString()));
+        assertThat(response.getBarcodeUri(), not(emptyOrNullString()));
+        assertThat(response.getRecoveryCodes(), notNullValue());
+    }
+
     @Test
     public void addOobAuthenticatorThrowsWhenTokenNull() {
         verifyThrows(IllegalArgumentException.class,
@@ -1605,6 +1637,20 @@ public void addOobAuthenticatorThrowsWhenChannelsNull() {
             "'OOB channels' cannot be null!");
     }
 
+    @Test
+    public void addOobAuthenticatorThrowsWhenChannelsNullWithPhoneNumber() {
+        verifyThrows(IllegalArgumentException.class,
+            () -> api.addOobAuthenticator("mfaToken", null, "phone-number", null),
+            "'OOB channels' cannot be null!");
+    }
+
+    @Test
+    public void addOobAuthenticatorThrowsWhenChannelsNullWithEmail() {
+        verifyThrows(IllegalArgumentException.class,
+            () -> api.addOobAuthenticator("mfaToken", null, null, "email-address"),
+            "'OOB channels' cannot be null!");
+    }
+
     @Test
     public void addOobAuthenticatorThrowsWhenPhoneNumberNull() {
         verifyThrows(IllegalArgumentException.class,
@@ -1674,9 +1720,32 @@ public void addOobAuthenticatorRequestWithEmail() throws Exception {
         assertThat(response.getRecoveryCodes(), notNullValue());
     }
 
+    @Test
+    public void addOobAuthenticatorRequestWithNoContactInfo() throws Exception {
+        Request<CreatedOobResponse> request = api.addOobAuthenticator("mfaToken", Collections.singletonList("auth0"), null, null);
+
+        server.jsonResponse(AUTH_OOB_AUTHENTICATOR_RESPONSE, 200);
+        CreatedOobResponse response = request.execute().getBody();
+        RecordedRequest recordedRequest = server.takeRequest();
+
+        assertThat(recordedRequest, hasMethodAndPath(HttpMethod.POST, "/mfa/associate"));
+        assertThat(recordedRequest, hasHeader("Content-Type", "application/json"));
+
+        Map<String, Object> body = bodyFromRequest(recordedRequest);
+        assertThat(body, hasEntry("authenticator_types", Collections.singletonList("oob")));
+        assertThat(body, hasEntry("oob_channels", Collections.singletonList("auth0")));
+
+        assertThat(response, is(notNullValue()));
+        assertThat(response.getAuthenticatorType(), not(emptyOrNullString()));
+        assertThat(response.getOobChannel(), not(emptyOrNullString()));
+        assertThat(response.getOobCode(), not(emptyOrNullString()));
+        assertThat(response.getBarcodeUri(), not(emptyOrNullString()));
+        assertThat(response.getRecoveryCodes(), notNullValue());
+    }
+
     @Test
     public void addOobAuthenticatorRequestWithMultipleChannels() throws Exception {
-        Request<CreatedOobResponse> request = api.addOobAuthenticator("mfaToken", Arrays.asList("sms", "email"), "phone-number", "email-address");
+        Request<CreatedOobResponse> request = api.addOobAuthenticator("mfaToken", Arrays.asList("sms", "email", "auth0"), "phone-number", "email-address");
 
         server.jsonResponse(AUTH_OOB_AUTHENTICATOR_RESPONSE, 200);
         CreatedOobResponse response = request.execute().getBody();
@@ -1687,7 +1756,7 @@ public void addOobAuthenticatorRequestWithMultipleChannels() throws Exception {
 
         Map<String, Object> body = bodyFromRequest(recordedRequest);
         assertThat(body, hasEntry("authenticator_types", Collections.singletonList("oob")));
-        assertThat(body, hasEntry("oob_channels", Arrays.asList("sms", "email")));
+        assertThat(body, hasEntry("oob_channels", Arrays.asList("sms", "email", "auth0")));
         assertThat(body, hasEntry("phone_number", "phone-number"));
         assertThat(body, hasEntry("email", "email-address"));