Skip to content

Commit 6a94678

Browse files
chore: remove package-lock.json (#1091)
## Summary - Remove `package-lock.json` and add it to `.gitignore` to better support alternative registries - Replace `npm ci` with `npm i` in all CI workflows (build, test, integration, publish actions) - Remove `cache: npm` from all `setup-node` steps and replace with `package-manager-cache: false` - Remove `registry-url` from `npm-publish` action (not needed with OIDC publishing) - Add explicit `npm i` step to `snyk.yml` (previously relied on the lockfile to trigger its own install)
1 parent a1cb3c5 commit 6a94678

File tree

8 files changed

+14
-13462
lines changed

8 files changed

+14
-13462
lines changed

.github/actions/build/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ runs:
1515
uses: actions/setup-node@v3
1616
with:
1717
node-version: ${{ inputs.node }}
18-
cache: 'npm'
18+
package-manager-cache: false
1919

2020
- name: Install dependencies
2121
shell: bash
22-
run: npm ci --include=dev
22+
run: npm i --include=dev
2323

2424
- name: Build package
2525
shell: bash

.github/actions/npm-publish/action.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,15 @@ runs:
2121
uses: actions/setup-node@v4
2222
with:
2323
node-version: ${{ inputs.node-version }}
24-
cache: 'npm'
25-
registry-url: 'https://registry.npmjs.org'
24+
package-manager-cache: false
2625

2726
- name: Update npm
2827
shell: bash
2928
run: npm install -g npm@11
3029

3130
- name: Install dependencies
3231
shell: bash
33-
run: npm ci --include=dev
32+
run: npm i --include=dev
3433

3534
- name: Build package
3635
if: inputs.require-build == 'true'

.github/workflows/browserstack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
uses: actions/setup-node@v6
3939
with:
4040
node-version: ${{ env.NODE_VERSION }}
41-
cache: npm
41+
package-manager-cache: false
4242

4343
- name: Build package
4444
uses: ./.github/actions/build

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
ref: ${{ github.event.pull_request.head.sha || github.ref }}
5050

5151
- name: Install dependencies
52-
run: npm ci
52+
run: npm i
5353

5454
- name: Install Cypress binary
5555
run: npx cypress install

.github/workflows/snyk.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ jobs:
3535
with:
3636
ref: ${{ github.event.pull_request.head.sha || github.ref }}
3737

38+
- name: Install dependencies
39+
run: npm i
40+
3841
- uses: snyk/actions/node@9adf32b1121593767fc3c057af55b55db032dc04 # pin@1.0.0
3942
env:
4043
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ jobs:
5151
uses: actions/setup-node@v6
5252
with:
5353
node-version: ${{ env.NODE_VERSION }}
54-
cache: npm
54+
package-manager-cache: false
5555

5656
- name: Install dependencies
57-
run: npm ci --include=dev
57+
run: npm i --include=dev
5858

5959
- name: Run tests
6060
run: npm run test

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,4 +107,6 @@ dist
107107
test-results
108108

109109
cypress/screenshots
110-
cypress/videos
110+
cypress/videos
111+
112+
package-lock.json

0 commit comments

Comments
 (0)