fix: recreate Auth0Client when configuration props change#904
Closed
gyaneshgouraw-okta wants to merge 3 commits intomainfrom
Closed
fix: recreate Auth0Client when configuration props change#904gyaneshgouraw-okta wants to merge 3 commits intomainfrom
gyaneshgouraw-okta wants to merge 3 commits intomainfrom
Conversation
6 tasks
Contributor
Author
|
After thorough review, we've decided not to proceed with the fix as it would create multiple Auth0Client instances. Prevent authentication state corruption |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves how the
Auth0Clientis created in theAuth0Providercomponent. It replacesuseStatewithuseMemoto ensure the client is properly recreated when key props (domain,clientId,audience,scope, etc.) change. This makes the component behavior more predictable and correct when props are updated.Fixes: #830
Changes
Auth0Providerto useuseMemoforAuth0Clientinstantiation.useStateimport fromsrc/auth0-provider.tsx.Tests
__tests__/auth-provider.test.tsxto verify that theAuth0Clientis correctly recreated whenclientId,audience, orscopeprops change.