fix: prevent unnecessary user object updates causing infinite loops#955
Closed
yogeshchoudhary147 wants to merge 1 commit intomainfrom
Closed
fix: prevent unnecessary user object updates causing infinite loops#955yogeshchoudhary147 wants to merge 1 commit intomainfrom
yogeshchoudhary147 wants to merge 1 commit intomainfrom
Conversation
2e35a6e to
049ed57
Compare
Uses lodash-es isEqual for deep equality comparison to check if user content has changed, preventing unnecessary state updates and infinite loops in useEffect hooks. Changes: - Added lodash-es dependency for deep equality checking - Updated GET_ACCESS_TOKEN_COMPLETE and HANDLE_REDIRECT_COMPLETE cases - State only updates when user content actually changes Fixes #787
049ed57 to
ec109c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling
getAccessTokenSilently(), the reducer creates a new user object reference even when the user data hasn't changed. This causes infinite loops inuseEffecthooks that depend on theuserobject.Example scenario:
Solution
Use deep equality comparison (
isEqualfromlodash-es) instead of reference equality (===) when checking if the user object has changed in the reducer.Changes
lodash-esdependency for deep equality checkingGET_ACCESS_TOKEN_COMPLETEandHANDLE_REDIRECT_COMPLETEcases in reducer to useisEqualTesting
Fixes #787