Skip to content

Commit aae1c83

Browse files
authored
Merge pull request #136 from auth0/fix/idp-domian-missing-tooltip
fix(react): add missing tooltip for idp domian tab
2 parents e8e59f3 + 16a0fbc commit aae1c83

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

packages/core/src/i18n/custom-messages/my-organization/idp-management/sso-domain/sso-domain-tab-types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ export interface SsoDomainTabMessages {
7070
status?: string;
7171
verify?: string;
7272
};
73+
actions?: {
74+
enable_domain_tooltip?: string;
75+
disable_domain_tooltip?: string;
76+
};
7377
domain_statuses?: {
7478
pending?: string;
7579
verified?: string;

packages/react/src/components/auth0/my-organization/shared/idp-management/sso-provider-edit/__tests__/sso-domain-tab-action-column.test.tsx

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ describe('SsoDomainTabActionsColumn', () => {
205205

206206
await waitFor(() => {
207207
const tooltip = screen.getByRole('tooltip', { hidden: true });
208-
expect(tooltip).toHaveTextContent('content.table.actions.disable_domain_tooltip');
208+
expect(tooltip).toHaveTextContent('table.actions.disable_domain_tooltip');
209209
});
210210
});
211211

@@ -221,7 +221,7 @@ describe('SsoDomainTabActionsColumn', () => {
221221

222222
await waitFor(() => {
223223
const tooltip = screen.getByRole('tooltip', { hidden: true });
224-
expect(tooltip).toHaveTextContent('content.table.actions.enable_domain_tooltip');
224+
expect(tooltip).toHaveTextContent('table.actions.enable_domain_tooltip');
225225
});
226226
});
227227

@@ -238,7 +238,7 @@ describe('SsoDomainTabActionsColumn', () => {
238238

239239
await waitFor(() => {
240240
const tooltip = screen.getByRole('tooltip', { hidden: true });
241-
expect(tooltip).toHaveTextContent('content.table.actions.disable_domain_tooltip');
241+
expect(tooltip).toHaveTextContent('table.actions.disable_domain_tooltip');
242242
});
243243

244244
unmount();
@@ -254,7 +254,7 @@ describe('SsoDomainTabActionsColumn', () => {
254254

255255
await waitFor(() => {
256256
const tooltip = screen.getByRole('tooltip', { hidden: true });
257-
expect(tooltip).toHaveTextContent('content.table.actions.enable_domain_tooltip');
257+
expect(tooltip).toHaveTextContent('table.actions.enable_domain_tooltip');
258258
});
259259
});
260260

@@ -267,7 +267,7 @@ describe('SsoDomainTabActionsColumn', () => {
267267

268268
await waitFor(() => {
269269
const tooltip = screen.getByRole('tooltip', { hidden: true });
270-
expect(tooltip).toHaveTextContent('content.table.actions.disable_domain_tooltip');
270+
expect(tooltip).toHaveTextContent('table.actions.disable_domain_tooltip');
271271
});
272272
});
273273

@@ -293,7 +293,7 @@ describe('SsoDomainTabActionsColumn', () => {
293293

294294
await waitFor(() => {
295295
const tooltip = screen.getByRole('tooltip', { hidden: true });
296-
expect(tooltip).toHaveTextContent('content.table.actions.disable_domain_tooltip');
296+
expect(tooltip).toHaveTextContent('table.actions.disable_domain_tooltip');
297297
});
298298
});
299299
});
@@ -384,13 +384,9 @@ describe('SsoDomainTabActionsColumn', () => {
384384
columns: {
385385
verify: 'Custom Verify',
386386
},
387-
},
388-
content: {
389-
table: {
390-
actions: {
391-
enable_domain_tooltip: 'Custom Enable',
392-
disable_domain_tooltip: 'Custom Disable',
393-
},
387+
actions: {
388+
enable_domain_tooltip: 'Custom Enable',
389+
disable_domain_tooltip: 'Custom Disable',
394390
},
395391
},
396392
};

packages/react/src/components/auth0/my-organization/shared/idp-management/sso-provider-edit/sso-domain-tab-action-column.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ export function SsoDomainTabActionsColumn({
6262
</TooltipTrigger>
6363
<TooltipContent>
6464
{providerHasDomain
65-
? t('content.table.actions.disable_domain_tooltip')
66-
: t('content.table.actions.enable_domain_tooltip')}
65+
? t('table.actions.disable_domain_tooltip')
66+
: t('table.actions.enable_domain_tooltip')}
6767
</TooltipContent>
6868
</Tooltip>
6969
) : (

0 commit comments

Comments
 (0)