fix(core): pass domain name for proxy fetcher#266
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
========================================
Coverage 89.42% 89.42%
========================================
Files 159 159
Lines 13325 13325
Branches 1357 1749 +392
========================================
Hits 11916 11916
Misses 1409 1409 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rax7389
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pass Auth0 domain to proxy-mode API clients instead of an empty string.
What: Changed domain: '' to domain: config.domain ?? '' in both createMyAccountClient and createMyOrganizationClient for proxy mode.
Why: In proxy mode, routing uses baseUrl, not domain. However, the domain is still needed to construct the audience auth parameter in the fetcher. Previously it was hardcoded to an empty string, making it unavailable. This aligns proxy mode with normal mode where the domain is already passed through.
Packages
packages/corepackages/reactexamplesReferences
Testing
How can this be verified? Note anything intentionally not covered by tests and why.
Checklist
Contributing