Skip to content

fix(core): pass domain name for proxy fetcher#266

Merged
NaveenChand755 merged 1 commit into
mainfrom
fix/domain-for-fetcher-proxy
May 5, 2026
Merged

fix(core): pass domain name for proxy fetcher#266
NaveenChand755 merged 1 commit into
mainfrom
fix/domain-for-fetcher-proxy

Conversation

@NaveenChand755
Copy link
Copy Markdown
Contributor

@NaveenChand755 NaveenChand755 commented May 4, 2026

Summary: Pass Auth0 domain to proxy-mode API clients instead of an empty string.

What: Changed domain: '' to domain: config.domain ?? '' in both createMyAccountClient and createMyOrganizationClient for proxy mode.

Why: In proxy mode, routing uses baseUrl, not domain. However, the domain is still needed to construct the audience auth parameter in the fetcher. Previously it was hardcoded to an empty string, making it unavailable. This aligns proxy mode with normal mode where the domain is already passed through.

Packages

  • packages/core
  • packages/react
  • examples

References

Testing

How can this be verified? Note anything intentionally not covered by tests and why.

  • This change adds unit test coverage
  • Tested for both SPA and RWA flows, all example apps working
  • All existing and new tests complete without errors

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (c1fa8fd) to head (2ae2579).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #266    +/-   ##
========================================
  Coverage   89.42%   89.42%            
========================================
  Files         159      159            
  Lines       13325    13325            
  Branches     1357     1749   +392     
========================================
  Hits        11916    11916            
  Misses       1409     1409            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NaveenChand755 NaveenChand755 merged commit a5faee2 into main May 5, 2026
6 checks passed
@NaveenChand755 NaveenChand755 deleted the fix/domain-for-fetcher-proxy branch May 5, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants