Skip to content

refactor(core): align re-exported type names with sdk types#268

Merged
harishsundar-okta merged 1 commit into
mainfrom
refactor/align-type-names-with-sdk
May 6, 2026
Merged

refactor(core): align re-exported type names with sdk types#268
harishsundar-okta merged 1 commit into
mainfrom
refactor/align-type-names-with-sdk

Conversation

@harishsundar-okta
Copy link
Copy Markdown
Contributor

@harishsundar-okta harishsundar-okta commented May 6, 2026

Summary

Renames 6 re-exported types in core to match their SDK type names 1:1, aligning them with the 26 other re-exports that already follow this convention.

Why

The local type aliases diverged from the SDK names, creating inconsistency and making it harder to trace types back to their SDK origin. Aligning names reduces confusion and improves maintainability.

What

Pure renames (4):

  • IdentityProvider → IdpKnownResponse
  • IdpBaseUserAttributeItem → BaseUserAttributeMapItem
  • IdpConfig → GetIdpConfigurationResponseContent
  • IdpConfigStrategyBase → IdentityProvidersConfigStrategyBase

Array-wrapped type resolution (2):

  • IdpUserAttributeMap (Item[] alias) → removed alias, re-exported IdpUserAttributeMapItem directly; consumers now use IdpUserAttributeMapItem[]
  • IdpProvisioningUserAttributeMap (Item[] alias) → removed alias, re-exported IdpProvisioningUserAttributeMapItem directly; consumers now use IdpProvisioningUserAttributeMapItem[]

Packages

  • packages/core
  • packages/react

Testing

All consumers across core, react, and examples updated. No runtime behavior changes. All 2,133 existing tests pass.

  • image
  • image

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (41c6b47) to head (9af8df9).

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #268    +/-   ##
========================================
  Coverage   89.42%   89.42%            
========================================
  Files         159      159            
  Lines       13325    13328     +3     
  Branches     1357     1827   +470     
========================================
+ Hits        11916    11919     +3     
  Misses       1409     1409            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harishsundar-okta harishsundar-okta marked this pull request as ready for review May 6, 2026 11:00
@harishsundar-okta harishsundar-okta merged commit 5cd929a into main May 6, 2026
6 checks passed
@harishsundar-okta harishsundar-okta deleted the refactor/align-type-names-with-sdk branch May 6, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants