feat(react): create use user mfa service hook and types#270
Open
NaveenChand755 wants to merge 7 commits intomainfrom
Open
feat(react): create use user mfa service hook and types#270NaveenChand755 wants to merge 7 commits intomainfrom
NaveenChand755 wants to merge 7 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 89.42% 89.47% +0.04%
==========================================
Files 159 160 +1
Lines 13329 13388 +59
Branches 1435 1435
==========================================
+ Hits 11920 11979 +59
Misses 1409 1409 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rax7389
reviewed
May 8, 2026
rax7389
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
useUserMFAService, an internal TanStack Query hook that handles MFA data fetching and mutations (enroll, delete, confirm). Separates the API layer from UI state as the foundation for useUserMFA in the next PR.Why
The existing MFA implementation bundles data fetching and UI state together, making the API layer hard to test in isolation. This extracts it as a standalone hook.
What
useUserMFAServicewith factorsQuery, enrollMutation, deleteMutation, confirmEnrollmentMutationUseUserMFAServiceReturn type + export from hooks/index.ts
10 unit tests
Packages
packages/corepackages/reactexamplesReferences
Testing
How can this be verified? Note anything intentionally not covered by tests and why.
Checklist
Contributing