feat(management-client): add userAttributeProfiles & organizations.discoveryDomains, remove groups, refactor client options (Don't merge)#1219
Closed
fern-api[bot] wants to merge 2 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 79.20% 79.34% +0.14%
==========================================
Files 580 507 -73
Lines 18155 18482 +327
Branches 8617 9053 +436
==========================================
+ Hits 14379 14664 +285
- Misses 3776 3818 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the management client codebase, focusing on unifying client option types, updating resource accessors, and enhancing developer tooling. The most significant changes include the extraction and consolidation of base client and request option types, the addition and removal of certain resource clients, and updates to developer scripts and dependencies.
Client and API Refactoring:
Extracted common client and request options into
BaseClientOptionsandBaseRequestOptionsin a newBaseClient.tsfile, and updated all relevant API and resource client interfaces to extend from these base types for improved consistency and maintainability.Updated the
Actionsresource client to use the new base option types and improved thelistmethod's example and query parameter handling for better type safety and clarity.Resource Changes in Management Client:
userAttributeProfilesandorganizations.discoveryDomainsresource accessor and removed thegroupsresource accessor from theManagementClient, reflecting changes in available API resources.API Exports and Error Files:
Added a new export for API request types via
src/management/api/requests/index.tsand updated the main API index file to include this export.Standardized the comment headers in all error files to a consistent single-line format.
Developer Tooling and Dependency Updates:
Added new formatting and linting scripts (
format:check,lint,lint:fix,check,check:fix) topackage.jsonfor improved code quality workflows.Updated the
mswandprettierdependencies to use fixed versions, and addedbiome.jsonto.npmignore.These changes collectively improve code maintainability, developer experience, and ensure the client reflects the current state of the API.