fix: update uuid dependency to version 14.0.0 and refactor import in …#1336
Closed
amitsingh05667 wants to merge 1 commit into
Closed
fix: update uuid dependency to version 14.0.0 and refactor import in …#1336amitsingh05667 wants to merge 1 commit into
amitsingh05667 wants to merge 1 commit into
Conversation
…client authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade uuid to v14
Why
uuid v14 dropped CommonJS (CJS) support - it's ESM-only. The previous static import was compiled by TypeScript to
require("uuid")in the CJS build, which throwsERR_REQUIRE_ESMat runtime.Changes
package.json- bumpeduuidfrom^11.1.0to^14.0.0src/auth/client-authentication.ts- replaced static import with dynamicawait import("uuid")inside the function, so the CJS build works correctlyNotes
if (clientAssertionSigningKey ...)block - uuid is only loaded when building a client assertion JWT