Skip to content

Update dependencies and enhance webAuth methods to support HTTPS#1125

Merged
subhankarmaiti merged 11 commits into
masterfrom
SDK-5760
Apr 16, 2025
Merged

Update dependencies and enhance webAuth methods to support HTTPS#1125
subhankarmaiti merged 11 commits into
masterfrom
SDK-5760

Conversation

@subhankarmaiti
Copy link
Copy Markdown
Contributor

@subhankarmaiti subhankarmaiti commented Apr 7, 2025 •
edited
Loading

Changes

  • Update dependencies and enhance webAuth methods to support HTTPS

References

Checklist

@subhankarmaiti subhankarmaiti requested a review from a team as a code owner April 7, 2025 05:05
@subhankarmaiti subhankarmaiti requested a review from Copilot April 7, 2025 05:11
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • ios/A0Auth0.m: Language not supported
  • ios/NativeBridge.swift: Language not supported

pmathew92
pmathew92 reviewed Apr 7, 2025
View reviewed changes
Comment thread src/webauth/agent.ts
pmathew92
pmathew92 reviewed Apr 7, 2025
View reviewed changes
Comment thread src/webauth/agent.ts Outdated
Widcket
Widcket reviewed Apr 11, 2025
View reviewed changes
Comment thread A0Auth0.podspec
Widcket
Widcket reviewed Apr 11, 2025
View reviewed changes
Comment thread EXAMPLES.md Outdated
Widcket
Widcket reviewed Apr 11, 2025
View reviewed changes
Comment thread EXAMPLES.md Outdated
Widcket
Widcket reviewed Apr 11, 2025
View reviewed changes
Comment thread FAQ.md Outdated
@Widcket
Copy link
Copy Markdown
Contributor

Widcket commented Apr 11, 2025

BTW, HTTPS callbacks should be the default and recommended option for Web Auth on iOS, so the README setup instructions should be updated accordingly. E.g.: https://github.com/auth0/Auth0.swift#configure-web-auth-ios--macos

@Widcket
Copy link
Copy Markdown
Contributor

Widcket commented Apr 11, 2025

(after which the instructions on EXAMPLES.md will be redundant, so these should be removed)

Widcket
Widcket reviewed Apr 14, 2025
View reviewed changes
Comment thread EXAMPLES.md Outdated
Widcket
Widcket reviewed Apr 14, 2025
View reviewed changes
Comment thread README.md
Widcket
Widcket reviewed Apr 15, 2025
View reviewed changes
Comment thread EXAMPLES.md Outdated
@subhankarmaiti subhankarmaiti enabled auto-merge (squash) April 15, 2025 17:25
@subhankarmaiti subhankarmaiti disabled auto-merge April 15, 2025 17:26
@subhankarmaiti subhankarmaiti merged commit fc88945 into master Apr 16, 2025
3 of 4 checks passed
@subhankarmaiti subhankarmaiti deleted the SDK-5760 branch April 16, 2025 05:23
This was referenced Apr 17, 2025
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmathew92 pmathew92 pmathew92 left review comments

Copilot code review Copilot Copilot left review comments

@Widcket Widcket Widcket approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@subhankarmaiti @Widcket @pmathew92