Skip to content

fix(ios): Ensure useSFSafariViewController: true correctly opens SFSafariViewController #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subhankarmaiti merged 3 commits into from
Jul 28, 2025
Merged

fix(ios): Ensure useSFSafariViewController: true correctly opens SFSafariViewController #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2078aa
refactor(native): Simplify presentation style handling in authorize m…
subhankarmaiti Jul 27, 2025
6cd964e
test(native): Update default presentationStyle value in NativeBridgeM…
subhankarmaiti Jul 28, 2025
3fc0204
fix(native): Update presentationStyle handling to use 99 as a default…
subhankarmaiti Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/platforms/native/bridge/NativeBridgeManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type {
NativeClearSessionOptions,
} from '../../../types';
import {
SafariViewControllerPresentationStyle,
type LocalAuthenticationOptions,
type NativeAuthorizeOptions,
} from '../../../types/platform-specific';
Expand Down Expand Up @@ -71,16 +72,11 @@ export class NativeBridgeManager implements INativeBridge {
parameters: WebAuthorizeParameters,
options: NativeAuthorizeOptions
): Promise<Credentials> {
let presentationStyle: number | undefined;
if (options.useSFSafariViewController === true) {
// If just `true`, default to a safe style like `fullScreen` (value 1 from our enum)
presentationStyle = 1;
} else if (typeof options.useSFSafariViewController === 'object') {
presentationStyle = options.useSFSafariViewController.presentationStyle;
} else {
// If false or undefined, pass undefined to the native layer.
presentationStyle = undefined;
}
let presentationStyle = options.useSFSafariViewController
? (options.useSFSafariViewController as { presentationStyle: number })
?.presentationStyle ??
SafariViewControllerPresentationStyle.fullScreen
: undefined;
const scheme =
parameters.redirectUrl?.split('://')[0] ?? options.customScheme;
const credential = await this.a0_call(
Expand All @@ -97,7 +93,8 @@ export class NativeBridgeManager implements INativeBridge {
parameters.invitationUrl,
options.leeway ?? 0,
options.ephemeralSession ?? false,
presentationStyle,
presentationStyle ?? 99, // Since we can't pass null to the native layer, and we need a value to represent this parameter is not set, we are using 99.
// //The native layer will check for this and ignore if the value is 99
parameters.additionalParameters ?? {}
);
return new CredentialsModel(credential);
Expand Down
2 changes: 1 addition & 1 deletion src/platforms/native/bridge/__tests__/NativeBridgeManager.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('NativeBridgeManager', () => {
undefined, // invitationUrl
0, // leeway
false, // ephemeralSession
undefined, // presentationStyle
99, // presentationStyle
{} // additionalParameters
);
});
Expand Down