fix: android intent-filter generation for packages with uppercase letters#1346
Merged
subhankarmaiti merged 2 commits intoOct 16, 2025
Merged
Conversation
pmathew92
previously approved these changes
Oct 16, 2025
pmathew92
approved these changes
Oct 16, 2025
hugoecken
pushed a commit
to hugoecken/react-native-auth0
that referenced
this pull request
Oct 29, 2025
hugoecken
pushed a commit
to hugoecken/react-native-auth0
that referenced
this pull request
Oct 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an Android application package name contains uppercase letters (e.g.,
com.testApp), the auto-generated intent-filter in the AndroidManifest file uses the original casing in thepathPrefixattribute. However, the callback URI generation already lowercases the bundle identifier, causing a mismatch that prevents the app from properly handling the Auth0 callback after authentication.Solution
This PR lowercases the
applicationIdin the Expo config plugin before using it to generate the Android intent-filter, ensuring consistency with the callback URI generation logic.Changed:
src/plugin/withAuth0.ts: ModifiedwithAndroidAuth0Manifestto lowercase the package name viaconfig.android?.package?.toLowerCase()This aligns with the existing behavior in
NativeWebAuthProvider.tswhere thebundleIdis lowercased when generating callback URIs.Impact
pathPrefixwill now consistently use lowercase package names, matching the callback URL structureTesting
com.testApp) can successfully authenticate and receive callbacksReferences