Skip to content

Detekt Lint Fix + Workflow Setup#37

Merged
pacific-ring merged 5 commits into
mainfrom
task/detekt-lint-fix-2
Jun 15, 2026
Merged

Detekt Lint Fix + Workflow Setup#37
pacific-ring merged 5 commits into
mainfrom
task/detekt-lint-fix-2

Conversation

@pacific-ring

Copy link
Copy Markdown
Contributor

Description

  1. Added Workflow support for detekt on github.
  2. Refactored code where code changed were required to resolve magic number issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvement

Checklist

@pacific-ring pacific-ring requested a review from a team as a code owner June 11, 2026 10:13
@pacific-ring pacific-ring requested a review from pmathew92 June 14, 2026 22:59
Comment thread config/detekt/detekt.yml
# Renaming it to drop the underscore would be a breaking change for consumers.
PackageNaming:
active: true
excludes: [ '**/mfa/authenticator_methods/**' ]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmathew92 this will be removed in upcoming PR where i am solving the component visibility issue

Comment thread config/detekt/detekt.yml
# authenticator_methods package is public API; renaming would break consumers.
PackageName:
active: true
excludes: [ '**/mfa/authenticator_methods/**' ]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmathew92 this will be removed in upcoming PR where i am solving the component visibility issue

@pacific-ring pacific-ring merged commit 9f676e3 into main Jun 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants