Skip to content

Fixed bugs#18

Merged
Sudhanshu96 merged 4 commits into
mainfrom
bugfix/logout_clear_web_cache
Apr 27, 2026
Merged

Fixed bugs#18
Sudhanshu96 merged 4 commits into
mainfrom
bugfix/logout_clear_web_cache

Conversation

@Sudhanshu96

@Sudhanshu96 Sudhanshu96 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  1. Clear web cache on logout.
  2. UI bug of logout button overlapping profile options on small screen at Welcome page.

📷 Screenshots

After fix
Simulator Screenshot - iPhone 16e - 2026-04-16 at 12 00 28

Before fix
Simulator Screenshot - iPhone 16e - 2026-04-16 at 15 07 42

1. Clear web cache on logout.
2. UI bug of logout button overlapping profile options on small screen at Welcome page.
@Sudhanshu96
Sudhanshu96 requested a review from a team as a code owner April 16, 2026 06:31
.clearSession(federated: false) { [weak self] result in
switch result {
case .success(_):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add a comment here too.
comment should include

  1. clear web browser cookies and delete session
  2. delete credentials stored in device keychain

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sudhanshu96
Sudhanshu96 merged commit df600e8 into main Apr 27, 2026
9 checks passed
@Sudhanshu96
Sudhanshu96 deleted the bugfix/logout_clear_web_cache branch April 27, 2026 06:52
Sudhanshu96 added a commit that referenced this pull request Apr 27, 2026
* Fixed the following bugs:
1. Clear web cache on logout.
2. UI bug of logout button overlapping profile options on small screen at Welcome page.

* Added descriptive comment
Sudhanshu96 added a commit that referenced this pull request Apr 29, 2026
* Incomplete error message issue fixed on Passkey registration failure

* Changed the onChange callback to onReceive as the later best works with @published publisher cause it guarantees response to a value change independent of SwiftUI's rendering pipeline (#19)

* Step-up flow fixed (#20)

* Bug fixed in Step-up flow fixed. Missing scope being passed causing the flow to trigger recursively

* Failing test case fixed

* Added documentation for scope related changes

* Fixed bugs (#18)

* Fixed the following bugs:
1. Clear web cache on logout.
2. UI bug of logout button overlapping profile options on small screen at Welcome page.

* Added descriptive comment

* Passkeys implementation issues fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants