security: bump openfga to v1.18.1, fixes GO-2026-5423#643
Open
lakhansamani wants to merge 1 commit into
Open
Conversation
github.com/openfga/openfga@v1.17.1 skips OIDC audience validation when --authn-oidc-audience is unset. We embed the FGA server in-process via server.WithDatastore and never wire its OIDC authn middleware, so the vulnerable path isn't reachable at runtime, but govulncheck flags it via static call-graph reachability and fails CI on every branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
govulncheckhas been failing onmainsince ~2026-06-29 (unrelated to any in-flight feature work):github.com/openfga/openfga@v1.17.1has a published advisory, GO-2026-5423 — OIDC audience validation is skipped when--authn-oidc-audienceis unset.We embed the FGA server in-process via
server.NewServerWithOpts(server.WithDatastore(ds))(internal/authorization/engine/openfga/openfga.go) and never wire its OIDC authn middleware or CLI flags, so the vulnerable code path isn't reachable at runtime.govulncheckstill flags it because the vulnerable symbols are statically reachable through theserverpackage's call graph — a false-positive from an exploitability standpoint, but a real CI gate failure.Change
Bump
github.com/openfga/openfgav1.17.1 → v1.18.1 (latest patch on top of the v1.18.0 fix version).Test plan
go build ./...cleango vet ./...cleanmake lint-go— 0 issuesTEST_DBS=sqlite go test -p 1 ./internal/authorization/... ./internal/service/...— passmake test-sqlite(full integration suite) — passgovulncheck ./...— no vulnerabilities found