Skip to content

Commit 20a9897

Browse files
authored
chore: add debug flag to LR (#166)
1 parent e986f0c commit 20a9897

3 files changed

Lines changed: 15 additions & 37 deletions

File tree

authzed/api/v1/core.proto

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,7 @@ message AlgebraicSubjectSet {
218218
not_in: [0]
219219
}
220220
];
221-
repeated PermissionRelationshipTree children = 2 [
222-
(validate.rules).repeated.items.message.required = true,
223-
(buf.validate.field).repeated.items.required = true
224-
];
221+
repeated PermissionRelationshipTree children = 2 [(validate.rules).repeated.items.message.required = true];
225222
}
226223

227224
// DirectSubjectSet is a subject set which is simply a collection of subjects.

authzed/api/v1/experimental_service.proto

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@ message BulkCheckPermissionRequest {
216216

217217
repeated BulkCheckPermissionRequestItem items = 2 [
218218
(validate.rules).repeated.items.message.required = true,
219-
(buf.validate.field).repeated.items.required = true,
220219
deprecated = true
221220
];
222221
}
@@ -255,10 +254,7 @@ message BulkCheckPermissionResponse {
255254
(buf.validate.field).required = false
256255
];
257256

258-
repeated BulkCheckPermissionPair pairs = 2 [
259-
(validate.rules).repeated.items.message.required = true,
260-
(buf.validate.field).repeated.items.required = true
261-
];
257+
repeated BulkCheckPermissionPair pairs = 2 [(validate.rules).repeated.items.message.required = true];
262258
}
263259

264260
message BulkCheckPermissionPair {
@@ -295,10 +291,7 @@ message BulkCheckPermissionResponseItem {
295291
// invocation are executed under this single transaction. If a relationship already
296292
// exists within the datastore, the entire transaction will fail with an error.
297293
message BulkImportRelationshipsRequest {
298-
repeated Relationship relationships = 1 [
299-
(validate.rules).repeated.items.message.required = true,
300-
(buf.validate.field).repeated.items.required = true
301-
];
294+
repeated Relationship relationships = 1 [(validate.rules).repeated.items.message.required = true];
302295
}
303296

304297
// BulkImportRelationshipsResponse is returned on successful completion of the

authzed/api/v1/permission_service.proto

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -379,15 +379,9 @@ message Precondition {
379379
// the write will be committed. All updates will be applied transactionally,
380380
// and if any preconditions fail, the entire transaction will be reverted.
381381
message WriteRelationshipsRequest {
382-
repeated RelationshipUpdate updates = 1 [
383-
(validate.rules).repeated.items.message.required = true,
384-
(buf.validate.field).repeated.items.required = true
385-
];
382+
repeated RelationshipUpdate updates = 1 [(validate.rules).repeated.items.message.required = true];
386383

387-
repeated Precondition optional_preconditions = 2 [
388-
(validate.rules).repeated.items.message.required = true,
389-
(buf.validate.field).repeated.items.required = true
390-
]; // To be bounded by configuration
384+
repeated Precondition optional_preconditions = 2 [(validate.rules).repeated.items.message.required = true]; // To be bounded by configuration
391385

392386
// optional_transaction_metadata is an optional field that can be used to store metadata about the transaction.
393387
// If specified, this metadata will be supplied in the WatchResponse for the updates associated with this
@@ -414,10 +408,7 @@ message DeleteRelationshipsRequest {
414408
(buf.validate.field).required = true
415409
];
416410

417-
repeated Precondition optional_preconditions = 2 [
418-
(validate.rules).repeated.items.message.required = true,
419-
(buf.validate.field).repeated.items.required = true
420-
]; // To be bounded by configuration
411+
repeated Precondition optional_preconditions = 2 [(validate.rules).repeated.items.message.required = true]; // To be bounded by configuration
421412

422413
// optional_limit, if non-zero, specifies the limit on the number of relationships to be deleted.
423414
// If there are more matching relationships found to be deleted than the limit specified here,
@@ -576,10 +567,7 @@ message CheckPermissionResponse {
576567
message CheckBulkPermissionsRequest {
577568
Consistency consistency = 1;
578569

579-
repeated CheckBulkPermissionsRequestItem items = 2 [
580-
(validate.rules).repeated.items.message.required = true,
581-
(buf.validate.field).repeated.items.required = true
582-
];
570+
repeated CheckBulkPermissionsRequestItem items = 2 [(validate.rules).repeated.items.message.required = true];
583571

584572
// with_tracing, if true, indicates that each response should include a debug trace.
585573
// This can be useful for debugging and performance analysis, but adds a small amount
@@ -621,10 +609,7 @@ message CheckBulkPermissionsResponse {
621609
(buf.validate.field).required = false
622610
];
623611

624-
repeated CheckBulkPermissionsPair pairs = 2 [
625-
(validate.rules).repeated.items.message.required = true,
626-
(buf.validate.field).repeated.items.required = true
627-
];
612+
repeated CheckBulkPermissionsPair pairs = 2 [(validate.rules).repeated.items.message.required = true];
628613
}
629614

630615
message CheckBulkPermissionsPair {
@@ -751,6 +736,12 @@ message LookupResourcesRequest {
751736
// optional_cursor, if specified, indicates the cursor after which results should resume being returned.
752737
// The cursor can be found on the LookupResourcesResponse object.
753738
Cursor optional_cursor = 7;
739+
//
740+
// with_debug, if true, indicates that the response should return debug information
741+
// if present and available. For now, ONLY enables debugging of maximum recursion depth
742+
// errors, with additional context being returned in error details, but this may be
743+
// extended in the future.
744+
bool with_debug = 8;
754745
}
755746

756747
// LookupPermissionship represents whether a Lookup response was partially evaluated or not
@@ -966,10 +957,7 @@ message ResolvedSubject {
966957
// invocation are executed under this single transaction. If a relationship already
967958
// exists within the datastore, the entire transaction will fail with an error.
968959
message ImportBulkRelationshipsRequest {
969-
repeated Relationship relationships = 1 [
970-
(validate.rules).repeated.items.message.required = true,
971-
(buf.validate.field).repeated.items.required = true
972-
];
960+
repeated Relationship relationships = 1 [(validate.rules).repeated.items.message.required = true];
973961
}
974962

975963
// ImportBulkRelationshipsResponse is returned on successful completion of the

0 commit comments

Comments
 (0)