Skip to content

CJS fix - fixes #219#220

Merged
tstirrat15 merged 1 commit into
authzed:mainfrom
jevy:commonjs-fix
Apr 16, 2025
Merged

CJS fix - fixes #219#220
tstirrat15 merged 1 commit into
authzed:mainfrom
jevy:commonjs-fix

Conversation

@jevy

@jevy jevy commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

Fixes #219

Credit to @noseworthy for the fix

Before
CleanShot 2025-04-16 at 09 14 13

With this fix
Notice how the import and types are found correctly.
CleanShot 2025-04-16 at 13 02 02@2x

@jevy jevy requested a review from a team as a code owner April 16, 2025 17:09
@github-actions

github-actions Bot commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tstirrat15

Copy link
Copy Markdown
Contributor

For posterity:

This is explicitly a problem in a CommonJS environment, and has to do with the typescript compiler refusing to pick up .d.ts files in a CommonJS context. This change appears to fix the problem for that specific case.

@jevy

jevy commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

authzedbot added a commit to authzed/cla that referenced this pull request Apr 16, 2025

@tstirrat15 tstirrat15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 merged commit fdf7660 into authzed:main Apr 16, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CommonJS types not built correctly

2 participants