fix: properly handle gzip-encoded responses#182
Closed
tstirrat15 wants to merge 3 commits intomainfrom
Closed
Conversation
github-actions
Bot
added
area/tooling
tstirrat15
force-pushed
the
tstirrat/properly-handle-gzipped-responses
branch
from
6d49d39 to
a073073
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 69.30% 62.57% -6.74%
==========================================
Files 27 25 -2
Lines 2864 2843 -21
==========================================
- Hits 1985 1779 -206
- Misses 623 773 +150
- Partials 256 291 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
force-pushed
the
tstirrat/properly-handle-gzipped-responses
branch
2 times, most recently
from
b74670c to
b78b286
Compare
ecordell
previously approved these changes
Mar 3, 2026
tstirrat15
force-pushed
the
tstirrat/properly-handle-gzipped-responses
branch
2 times, most recently
from
81d1745 to
3b2c2b8
Compare
tstirrat15
force-pushed
the
tstirrat/properly-handle-gzipped-responses
branch
from
3b2c2b8 to
c53a8e1
Compare
FilterResp detects `Content-Encoding: gzip` and decompresses the body into plain bytes. But it never removed the `Content-Encoding: gzip` header before passing the response back to the client
…-responses-2 delete gzip header once decompressed
Contributor
Author
|
Closing in favor of #184. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've been seeing an issue with a system using this proxy and one of the characteristics is that the response is large - 200kb or so. @ivanauth pointed out that the k8s API will automatically gzip requests above 128kb, and we verified that we weren't handling that properly.
Developed with AI tooling help.
Changes
Testing
Revie.