Skip to content

Commit 8908ebe

Browse files
authored
chore: add buffnet authority to connection (#3168)
## Description This is a behavior I missed in #3147. The `GRPCDialContext` for buffered connections was setting this authority flag. ## Changes * Reinstate the flag ## Testing Review.
1 parent 87482ed commit 8908ebe

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
99

1010
### Changed
1111
- Cache: switch to [otter](https://maypok86.github.io/otter/) as the primary cache implementation (https://github.com/authzed/spicedb/pull/3112)
12+
- Server handles: `GRPCDialContext` as a handle on the server used deprecated gRPC methods. We modernized it and renamed it to `NewClient` (https://github.com/authzed/spicedb/pull/3147)
1213

1314
### Fixed
1415
- The watching schema cache (`--enable-experimental-watchable-schema-cache`) no longer enters permanent fallback on transient watch errors. A new supervisor restarts the watch cycle with bounded exponential backoff and only treats caller-driven cancellation or unsupported-watch as terminal (https://github.com/authzed/spicedb/pull/3134)

internal/grpchelpers/grpchelpers.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ func NewBufferedClient(listener *bufconn.Listener, opts ...grpc.DialOption) (*gr
2323
return listener.DialContext(ctx)
2424
}),
2525
grpc.WithTransportCredentials(insecure.NewCredentials()),
26+
// This identifies the client to the server as being over the buffered network
27+
grpc.WithAuthority("buffnet"),
2628
}, opts...)
2729
return grpc.NewClient("passthrough:///localhost", opts...)
2830
}

0 commit comments

Comments
 (0)