Support mocking delegate types (#48)#60
Merged
Merged
Conversation
Mock<T>() now uses Moq.Mock.Get instead of casting the resolved object to IMocked<T>. A delegate mock's Object is the delegate itself and does not implement IMocked<T>, so the previous cast threw InvalidCastException.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #60 +/- ##
===========================================
- Coverage 90.99% 90.90% -0.09%
===========================================
Files 3 3
Lines 111 110 -1
Branches 21 21
===========================================
- Hits 101 100 -1
Misses 6 6
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48.
Problem
AutoMock.Mock<T>()cast the resolved object toIMocked<T>:For interfaces and classes, Moq's proxy
.ObjectimplementsIMocked<T>, so this works. But for a delegate mock,.Objectis the delegate itself and does not implementIMocked<T>, so the cast threw:Fix
Use
Moq.Mock.Get(...)instead of the cast.Mock.Getretrieves theMock<T>from Moq's internal registry rather than relying on the resolved object implementingIMocked<T>, so it works for delegate mocks as well as interfaces and classes.Tests
Added a regression test that mocks a delegate type, sets it up, and invokes it. Full suite passes (49 tests).