Test cleanup.

Author: tillig

test/Autofac.Pooling.Test/ConcurrencyTests.cs

@@ -13,8 +13,9 @@ public async Task CanUsePoolConcurrently()
     {
         var builder = new ContainerBuilder();
 
-        builder.RegisterType<PooledComponent>().As<IPooledService>()
-                                               .PooledInstancePerLifetimeScope();
+        builder.RegisterType<PooledComponent>()
+               .As<IPooledService>()
+               .PooledInstancePerLifetimeScope();
 
         var container = builder.Build();
 
@@ -39,8 +40,9 @@ public async Task CanUsePoolConcurrentlyWithCustomPolicyToBlockOnMaxUsage()
 
         using var blockingPolicy = new BlockingPolicy<PooledComponent>(4);
 
-        builder.RegisterType<PooledComponent>().As<IPooledService>()
-                                               .PooledInstancePerLifetimeScope(blockingPolicy);
+        builder.RegisterType<PooledComponent>()
+            .As<IPooledService>()
+            .PooledInstancePerLifetimeScope(blockingPolicy);
 
         var container = builder.Build();
 

test/Autofac.Pooling.Test/CustomProviderTests.cs

@@ -292,7 +292,7 @@ public void Provider_DisposableCustomPoolDisposedAtShutdown()
     }
 
     [Fact]
-    public void Provider_NullProviderFactoryThrows()
+    public void Provider_NullProviderFactory()
     {
         var builder = new ContainerBuilder();
 
@@ -305,7 +305,7 @@ public void Provider_NullProviderFactoryThrows()
     }
 
     [Fact]
-    public void Provider_NullProviderFactoryWithPolicyThrows()
+    public void Provider_NullProviderFactoryWithPolicy()
     {
         var builder = new ContainerBuilder();
 
@@ -315,11 +315,11 @@ public void Provider_NullProviderFactoryWithPolicyThrows()
         Assert.Throws<ArgumentNullException>(() =>
             reg.PooledInstancePerLifetimeScope(
                 ctx => new DefaultPooledRegistrationPolicy<PooledComponent>(),
-                (Func<IComponentContext, ObjectPoolProvider>)null!));
+                null!));
     }
 
     [Fact]
-    public void Provider_NullPolicyFactoryWithProviderThrows()
+    public void Provider_NullPolicyFactoryWithProvider()
     {
         var builder = new ContainerBuilder();
 
@@ -328,12 +328,12 @@ public void Provider_NullPolicyFactoryWithProviderThrows()
 
         Assert.Throws<ArgumentNullException>(() =>
             reg.PooledInstancePerLifetimeScope(
-                (Func<IComponentContext, IPooledRegistrationPolicy<PooledComponent>>)null!,
+                null!,
                 ctx => new TrackingObjectPoolProvider()));
     }
 
     [Fact]
-    public void Provider_NullProviderFactoryWithMatchingScopeThrows()
+    public void Provider_NullProviderFactoryWithMatchingScope()
     {
         var builder = new ContainerBuilder();
 

test/Autofac.Pooling.Test/DefaultPooledRegistrationPolicyTests.cs

@@ -8,38 +8,38 @@ namespace Autofac.Pooling.Test;
 public class DefaultPooledRegistrationPolicyTests
 {
     [Fact]
-    public void DefaultConstructorUsesTwiceProcessorCount()
+    public void Ctor_MaximumRetainedUsesSuppliedValue()
     {
-        var policy = new DefaultPooledRegistrationPolicy<PooledComponent>();
+        var policy = new DefaultPooledRegistrationPolicy<PooledComponent>(3);
 
-        Assert.Equal(Environment.ProcessorCount * 2, policy.MaximumRetained);
+        Assert.Equal(3, policy.MaximumRetained);
     }
 
     [Fact]
-    public void MaximumRetainedConstructorUsesSuppliedValue()
+    public void Ctor_MaximumRetainedUsesTwiceProcessorCount()
     {
-        var policy = new DefaultPooledRegistrationPolicy<PooledComponent>(3);
+        var policy = new DefaultPooledRegistrationPolicy<PooledComponent>();
 
-        Assert.Equal(3, policy.MaximumRetained);
+        Assert.Equal(Environment.ProcessorCount * 2, policy.MaximumRetained);
     }
 
     [Fact]
-    public void ZeroMaximumRetainedIsAllowed()
+    public void Ctor_ZeroMaximumRetainedIsAllowed()
     {
         var policy = new DefaultPooledRegistrationPolicy<PooledComponent>(0);
 
         Assert.Equal(0, policy.MaximumRetained);
     }
 
     [Fact]
-    public void NegativeMaximumRetainedThrows()
+    public void Ctor_NegativeMaximumRetainedThrows()
     {
         Assert.Throws<ArgumentOutOfRangeException>(() =>
             new DefaultPooledRegistrationPolicy<PooledComponent>(-1));
     }
 
     [Fact]
-    public void GetInvokesTheGetFromPoolCallback()
+    public void Get_InvokesTheGetFromPoolCallback()
     {
         var policy = new DefaultPooledRegistrationPolicy<PooledComponent>();
         using var expected = new PooledComponent();
@@ -50,7 +50,7 @@ public void GetInvokesTheGetFromPoolCallback()
     }
 
     [Fact]
-    public void GetWithNullGetFromPoolThrows()
+    public void Get_NullGetFromPool()
     {
         var policy = new DefaultPooledRegistrationPolicy<PooledComponent>();
 
@@ -59,7 +59,7 @@ public void GetWithNullGetFromPoolThrows()
     }
 
     [Fact]
-    public void ReturnAlwaysAcceptsTheInstance()
+    public void Return_AlwaysAcceptsTheInstance()
     {
         var policy = new DefaultPooledRegistrationPolicy<PooledComponent>();
         using var instance = new PooledComponent();

test/Autofac.Pooling.Test/Examples/Caching/ConnectionConsumer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Autofac Project. All rights reserved.
+// Copyright (c) Autofac Project. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
 namespace Autofac.Pooling.Test.Examples.Caching;

test/Autofac.Pooling.Test/Examples/Caching/MyCustomConnection.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Autofac Project. All rights reserved.
+// Copyright (c) Autofac Project. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
 using Autofac.Core;

test/Autofac.Pooling.Test/FactoryOverloadTests.cs

@@ -208,7 +208,7 @@ public void PolicyFactory_DisposableRegistrationsDisposedWhenContainerIsDisposed
     }
 
     [Fact]
-    public void PolicyFactory_NullPolicyFactoryThrows()
+    public void PolicyFactory_NullPolicyFactory()
     {
         var builder = new ContainerBuilder();
 
@@ -221,7 +221,7 @@ public void PolicyFactory_NullPolicyFactoryThrows()
     }
 
     [Fact]
-    public void PolicyFactory_NullPolicyFactoryWithMatchingScopeThrows()
+    public void PolicyFactory_NullPolicyFactoryWithMatchingScope()
     {
         var builder = new ContainerBuilder();
 

test/Autofac.Pooling.Test/PoolServiceTests.cs

@@ -9,7 +9,7 @@ namespace Autofac.Pooling.Test;
 public class PoolServiceTests
 {
     [Fact]
-    public void DescriptionIncludesTheLimitType()
+    public void Ctor_DescriptionIncludesTheLimitType()
     {
         var registration = RegistrationFor<PooledComponent>();
 
@@ -19,7 +19,7 @@ public void DescriptionIncludesTheLimitType()
     }
 
     [Fact]
-    public void EqualsIsTrueForTheSameUnderlyingRegistration()
+    public void Equals_SameUnderlyingRegistration()
     {
         var registration = RegistrationFor<PooledComponent>();
 
@@ -31,7 +31,7 @@ public void EqualsIsTrueForTheSameUnderlyingRegistration()
     }
 
     [Fact]
-    public void EqualsIsFalseForDifferentRegistrations()
+    public void Equals_DifferentRegistrations()
     {
         var first = new PoolService(RegistrationFor<PooledComponent>());
         var second = new PoolService(RegistrationFor<OtherPooledComponent>());
@@ -40,7 +40,7 @@ public void EqualsIsFalseForDifferentRegistrations()
     }
 
     [Fact]
-    public void EqualsObjectMatchesAnotherPoolService()
+    public void EqualsObject_MatchesAnotherPoolService()
     {
         var registration = RegistrationFor<PooledComponent>();
 
@@ -51,7 +51,7 @@ public void EqualsObjectMatchesAnotherPoolService()
     }
 
     [Fact]
-    public void EqualsObjectIsFalseForUnrelatedType()
+    public void EqualsObject_UnrelatedType()
     {
         var service = new PoolService(RegistrationFor<PooledComponent>());
 
@@ -60,7 +60,7 @@ public void EqualsObjectIsFalseForUnrelatedType()
 
     [Fact]
     [SuppressMessage("CA1508", "CA1508", Justification = "Deliberately exercising the Equals null branch for coverage.")]
-    public void EqualsIsFalseForNull()
+    public void EqualsObject_Null()
     {
         var service = new PoolService(RegistrationFor<PooledComponent>());