Fix analyzer issues.

Author: tillig

test/Autofac.Pooling.Test/Common/PooledComponent.cs

@@ -4,6 +4,7 @@
 
 namespace Autofac.Pooling.Tests.Common;
 
+[SuppressMessage("CA1063", "CA1063", Justification = "Dispose remains simple here for testing.")]
 public class PooledComponent : IPooledService, IPooledComponent, IDisposable
 {
     public int GetCalled
@@ -31,6 +32,7 @@ public void OnReturnToPool()
         ReturnCalled++;
     }
 
+    [SuppressMessage("CA1063", "CA1063", Justification = "Dispose remains simple here for testing.")]
     public void Dispose()
     {
         DisposeCalled++;

test/Autofac.Pooling.Test/ConcurrencyTests.cs

@@ -41,7 +41,7 @@ public async Task CanUsePoolConcurrentlyWithCustomPolicyToBlockOnMaxUsage()
     {
         var builder = new ContainerBuilder();
 
-        var blockingPolicy = new BlockingPolicy<PooledComponent>(4);
+        using var blockingPolicy = new BlockingPolicy<PooledComponent>(4);
 
         builder.RegisterType<PooledComponent>().As<IPooledService>()
                                                .PooledInstancePerLifetimeScope(blockingPolicy);
@@ -60,10 +60,11 @@ await Task.WhenAll(Enumerable.Range(0, 10000).Select(i => Task.Run(() =>
         container.Dispose();
     }
 
-    private class BlockingPolicy<TLimit> : DefaultPooledRegistrationPolicy<TLimit>
+    private class BlockingPolicy<TLimit> : DefaultPooledRegistrationPolicy<TLimit>, IDisposable
         where TLimit : class
     {
         private readonly SemaphoreSlim _semaphore;
+        private bool _disposedValue;
 
         public BlockingPolicy(int maxConcurrentInstances) : base(maxConcurrentInstances)
         {
@@ -87,5 +88,25 @@ public override bool Return(TLimit pooledObject)
 
             return base.Return(pooledObject);
         }
+
+        protected virtual void Dispose(bool disposing)
+        {
+            if (!_disposedValue)
+            {
+                if (disposing)
+                {
+                    _semaphore.Dispose();
+                }
+
+                _disposedValue = true;
+            }
+        }
+
+        public void Dispose()
+        {
+            // Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
+            Dispose(disposing: true);
+            GC.SuppressFinalize(this);
+        }
     }
 }

test/Autofac.Pooling.Test/PoolingTests.cs

@@ -1,7 +1,7 @@
 using Autofac.Pooling.Tests.Common;
 using Xunit;
 
-namespace Autofac.Pooling.Tests;
+namespace Autofac.Pooling.Test;
 
 public class PoolingTest
 {